netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: torvalds@linux-foundation.org, davem@davemloft.net,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	pabeni@redhat.com, Guo Weikang <guoweikang.kernel@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [GIT PULL] Networking for v6.13-rc7
Date: Mon, 20 Jan 2025 09:45:47 -0800	[thread overview]
Message-ID: <20250120094547.202f4718@kernel.org> (raw)
In-Reply-To: <Z45i4YT1YRccf4dH@arm.com>

On Mon, 20 Jan 2025 14:51:13 +0000 Catalin Marinas wrote:
> > +#include <linux/kmemleak.h>
> >  #include <linux/memblock.h>
> >  #include <linux/printk.h>
> >  #include <linux/numa.h>
> > @@ -23,6 +24,9 @@ void __init alloc_node_data(int nid)
> >  		      nd_size, nid);
> >  	nd = __va(nd_pa);
> >  
> > +	/* needed to track related allocation stored in node_data[] */
> > +	kmemleak_alloc(nd, nd_size, 0, 0);
> > +
> >  	/* report and initialize */
> >  	pr_info("NODE_DATA(%d) allocated [mem %#010Lx-%#010Lx]\n", nid,
> >  		nd_pa, nd_pa + nd_size - 1);  
> 
> Hmm, I don't think this would make any difference as kmemleak does scan
> the memblock allocations as long as they have a correspondent VA in the
> linear map.
> 
> BTW, is NUMA enabled or disabled in your .config?

It's pretty much kernel/configs/debug.config, with virtme-ng, booted
with 4 CPUs. LMK if you can't repro with that, I can provide exact
cmdline.

  reply	other threads:[~2025-01-20 17:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-09 18:29 [GIT PULL] Networking for v6.13-rc7 Jakub Kicinski
2025-01-09 23:21 ` pr-tracker-bot
2025-01-17  3:38   ` Jakub Kicinski
2025-01-18 13:45     ` Catalin Marinas
2025-01-20 14:51       ` Catalin Marinas
2025-01-20 17:45         ` Jakub Kicinski [this message]
2025-01-21 11:09           ` Catalin Marinas
2025-01-21 15:42             ` Jakub Kicinski
2025-01-21 20:46               ` Catalin Marinas
2025-01-23 17:11                 ` Matthieu Baerts
2025-01-24 18:07                   ` Andrea Righi
2025-01-27 14:27                   ` Catalin Marinas
2025-01-27 17:39                     ` Matthieu Baerts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250120094547.202f4718@kernel.org \
    --to=kuba@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=catalin.marinas@arm.com \
    --cc=davem@davemloft.net \
    --cc=guoweikang.kernel@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).