netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Mateusz Polchlopek <mateusz.polchlopek@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
	Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1] ice: refactor ice_fdir_create_dflt_rules() function
Date: Mon, 20 Jan 2025 11:06:38 +0000	[thread overview]
Message-ID: <20250120110638.GW6206@kernel.org> (raw)
In-Reply-To: <20250117080632.10053-1-mateusz.polchlopek@intel.com>

On Fri, Jan 17, 2025 at 09:06:32AM +0100, Mateusz Polchlopek wrote:
> The Flow Director function ice_fdir_create_dflt_rules() calls few
> times function ice_create_init_fdir_rule() each time with different
> enum ice_fltr_ptype parameter. Next step is to return error code if
> error occurred.
> 
> Change the code to store all necessary default rules in constant array
> and call ice_create_init_fdir_rule() in the loop. It makes it easy to
> extend the list of default rules in the future, without the need of
> duplicate code more and more.
> 
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> Signed-off-by: Mateusz Polchlopek <mateusz.polchlopek@intel.com>

Reviewed-by: Simon Horman <horms@kernel.org>

  reply	other threads:[~2025-01-20 11:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-17  8:06 [Intel-wired-lan] [PATCH iwl-next v1] ice: refactor ice_fdir_create_dflt_rules() function Mateusz Polchlopek
2025-01-20 11:06 ` Simon Horman [this message]
2025-02-03  3:49 ` Rinitha, SX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250120110638.GW6206@kernel.org \
    --to=horms@kernel.org \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=mateusz.polchlopek@intel.com \
    --cc=michal.swiatkowski@linux.intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).