From: Jakub Kicinski <kuba@kernel.org>
To: Kory Maincent <kory.maincent@bootlin.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>,
thomas.petazzoni@bootlin.com, Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next v3] net: phy: Fix suspicious rcu_dereference usage
Date: Mon, 20 Jan 2025 11:12:28 -0800 [thread overview]
Message-ID: <20250120111228.6bd61673@kernel.org> (raw)
In-Reply-To: <20250120141926.1290763-1-kory.maincent@bootlin.com>
On Mon, 20 Jan 2025 15:19:25 +0100 Kory Maincent wrote:
> The path reported to not having RTNL lock acquired is the suspend path of
> the ravb MAC driver. Without this fix we got this warning:
I maintain that ravb is buggy, plenty of drivers take rtnl_lock
from the .suspend callback. We need _some_ write protection here,
the patch as is only silences a legitimate warning.
--
pw-bot: cr
next prev parent reply other threads:[~2025-01-20 19:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-20 14:19 [PATCH net-next v3] net: phy: Fix suspicious rcu_dereference usage Kory Maincent
2025-01-20 19:12 ` Jakub Kicinski [this message]
2025-01-21 9:38 ` Kory Maincent
2025-01-21 10:02 ` Russell King (Oracle)
2025-01-21 10:29 ` Claudiu Beznea
2025-01-21 11:34 ` Paul Barker
2025-01-21 13:01 ` Kory Maincent
2025-01-21 15:44 ` Paul Barker
2025-01-21 16:11 ` Kory Maincent
2025-01-22 14:03 ` Paul Barker
2025-01-22 16:12 ` Kory Maincent
2025-01-23 11:25 ` Claudiu Beznea
2025-01-23 14:05 ` Kory Maincent
2025-01-23 15:45 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250120111228.6bd61673@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kory.maincent@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).