From: Jakub Kicinski <kuba@kernel.org>
To: Antoine Tenart <atenart@kernel.org>
Cc: davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
stephen@networkplumber.org, gregkh@linuxfoundation.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next 3/4] net-sysfs: prevent uncleared queues from being re-added
Date: Mon, 20 Jan 2025 11:44:00 -0800 [thread overview]
Message-ID: <20250120114400.55fffeda@kernel.org> (raw)
In-Reply-To: <20250117102612.132644-4-atenart@kernel.org>
On Fri, 17 Jan 2025 11:26:10 +0100 Antoine Tenart wrote:
> + if (unlikely(kobj->state_initialized))
> + return -EAGAIN;
we could do some weird stuff here like try to ignore the sysfs
objects and "resynchronize" them before releasing rtnl.
Way to hacky to do now, but also debugging a transient EAGAIN
will be a major PITA. How about we add a netdev_warn_once()
here to leave a trace of what happened in the logs?
next prev parent reply other threads:[~2025-01-20 19:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-17 10:26 [PATCH net-next 0/4] net-sysfs: remove the rtnl_trylock/restart_syscall construction Antoine Tenart
2025-01-17 10:26 ` [PATCH net-next 1/4] net-sysfs: remove rtnl_trylock from device attributes Antoine Tenart
2025-01-17 17:03 ` Stephen Hemminger
2025-01-17 18:35 ` Antoine Tenart
2025-01-17 10:26 ` [PATCH net-next 2/4] net-sysfs: move queue attribute groups outside the default groups Antoine Tenart
2025-01-17 10:26 ` [PATCH net-next 3/4] net-sysfs: prevent uncleared queues from being re-added Antoine Tenart
2025-01-20 19:44 ` Jakub Kicinski [this message]
2025-01-21 9:33 ` Antoine Tenart
2025-01-21 17:09 ` Jakub Kicinski
2025-01-22 8:34 ` Antoine Tenart
2025-01-17 10:26 ` [PATCH net-next 4/4] net-sysfs: remove rtnl_trylock from queue attributes Antoine Tenart
2025-01-20 19:40 ` [PATCH net-next 0/4] net-sysfs: remove the rtnl_trylock/restart_syscall construction Jakub Kicinski
2025-01-21 9:38 ` Antoine Tenart
2025-01-22 8:50 ` Maxime Chevallier
2025-01-22 9:09 ` Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250120114400.55fffeda@kernel.org \
--to=kuba@kernel.org \
--cc=atenart@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).