Re: [PATCH] Documentation/networking: Fix basic node example document ISO 15765-2

Re: [PATCH] Documentation/networking: Fix basic node example document ISO 15765-2

[Jonathan Corbet]

[CC += netdev - they may want a resend after the merge window though]

Reyders Morales <reyders1@gmail.com> writes:

> In the current struct sockaddr_can tp is member of can_addr.
> tp is not member of struct sockaddr_can.
>
> Signed-off-by: Reyders Morales <reyders1@gmail.com>
> ---
>  Documentation/networking/iso15765-2.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/networking/iso15765-2.rst b/Documentation/networking/iso15765-2.rst
> index 0e9d96074178..37ebb2c417cb 100644
> --- a/Documentation/networking/iso15765-2.rst
> +++ b/Documentation/networking/iso15765-2.rst
> @@ -369,8 +369,8 @@ to their default.
>  
>    addr.can_family = AF_CAN;
>    addr.can_ifindex = if_nametoindex("can0");
> -  addr.tp.tx_id = 0x18DA42F1 | CAN_EFF_FLAG;
> -  addr.tp.rx_id = 0x18DAF142 | CAN_EFF_FLAG;
> +  addr.can_addr.tp.tx_id = 0x18DA42F1 | CAN_EFF_FLAG;
> +  addr.can_addr.tp.rx_id = 0x18DAF142 | CAN_EFF_FLAG;
>  
>    ret = bind(s, (struct sockaddr *)&addr, sizeof(addr));
>    if (ret < 0)
> -- 
> 2.43.0

Re: [PATCH] Documentation/networking: Fix basic node example document ISO 15765-2

[Jakub Kicinski]

On Tue, 21 Jan 2025 17:06:08 -0700 Jonathan Corbet wrote:
> [CC += netdev - they may want a resend after the merge window though]

Thanks! Yes, please resend after the merge window, and also include 
linux-can@vger.kernel.org at that time (ideally just run the patch 
thru scripts/get_maintainer.pl to get the full CC list).

[PATCH] Documentation/networking: Fix basic node example document ISO 15765-2

[Reyders Morales]

In the current struct sockaddr_can tp is member of can_addr.
tp is not member of struct sockaddr_can.

Signed-off-by: Reyders Morales <reyders1@gmail.com>
---
 Documentation/networking/iso15765-2.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/networking/iso15765-2.rst b/Documentation/networking/iso15765-2.rst
index 0e9d96074178..37ebb2c417cb 100644
--- a/Documentation/networking/iso15765-2.rst
+++ b/Documentation/networking/iso15765-2.rst
@@ -369,8 +369,8 @@ to their default.
 
   addr.can_family = AF_CAN;
   addr.can_ifindex = if_nametoindex("can0");
-  addr.tp.tx_id = 0x18DA42F1 | CAN_EFF_FLAG;
-  addr.tp.rx_id = 0x18DAF142 | CAN_EFF_FLAG;
+  addr.can_addr.tp.tx_id = 0x18DA42F1 | CAN_EFF_FLAG;
+  addr.can_addr.tp.rx_id = 0x18DAF142 | CAN_EFF_FLAG;
 
   ret = bind(s, (struct sockaddr *)&addr, sizeof(addr));
   if (ret < 0)
-- 
2.43.0

Re: [PATCH] Documentation/networking: Fix basic node example document ISO 15765-2

[Oliver Hartkopp]

On 03.02.25 23:47, Reyders Morales wrote:
> In the current struct sockaddr_can tp is member of can_addr.
> tp is not member of struct sockaddr_can.
> 
> Signed-off-by: Reyders Morales <reyders1@gmail.com>

Acked-by: Oliver Hartkopp <socketcan@hartkopp.net>

Thanks!

> ---
>   Documentation/networking/iso15765-2.rst | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/networking/iso15765-2.rst b/Documentation/networking/iso15765-2.rst
> index 0e9d96074178..37ebb2c417cb 100644
> --- a/Documentation/networking/iso15765-2.rst
> +++ b/Documentation/networking/iso15765-2.rst
> @@ -369,8 +369,8 @@ to their default.
>   
>     addr.can_family = AF_CAN;
>     addr.can_ifindex = if_nametoindex("can0");
> -  addr.tp.tx_id = 0x18DA42F1 | CAN_EFF_FLAG;
> -  addr.tp.rx_id = 0x18DAF142 | CAN_EFF_FLAG;
> +  addr.can_addr.tp.tx_id = 0x18DA42F1 | CAN_EFF_FLAG;
> +  addr.can_addr.tp.rx_id = 0x18DAF142 | CAN_EFF_FLAG;
>   
>     ret = bind(s, (struct sockaddr *)&addr, sizeof(addr));
>     if (ret < 0)

Re: [PATCH] Documentation/networking: Fix basic node example document ISO 15765-2

[Simon Horman]

On Mon, Feb 03, 2025 at 11:47:20PM +0100, Reyders Morales wrote:
> In the current struct sockaddr_can tp is member of can_addr.
> tp is not member of struct sockaddr_can.
> 
> Signed-off-by: Reyders Morales <reyders1@gmail.com>

Reviewed-by: Simon Horman <horms@kernel.org>

Re: [PATCH] Documentation/networking: Fix basic node example document ISO 15765-2

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 525 bytes --]

On 03.02.2025 23:47:20, Reyders Morales wrote:
> In the current struct sockaddr_can tp is member of can_addr.
> tp is not member of struct sockaddr_can.
> 
> Signed-off-by: Reyders Morales <reyders1@gmail.com>

Applied to linux-can.

Thanks,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]