From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, pabeni@redhat.com,
andrew+netdev@lunn.ch, horms@kernel.org,
dan.carpenter@linaro.org, nbd@nbd.name, lorenzo@kernel.org,
ryder.lee@mediatek.com, shayne.chen@mediatek.com,
sean.wang@mediatek.com, kvalo@kernel.org, matthias.bgg@gmail.com,
angelogioacchino.delregno@collabora.com, quan.zhou@mediatek.com,
johannes.berg@intel.com, emmanuel.grumbach@intel.com,
leitao@debian.org, mingyen.hsieh@mediatek.com,
leon.yen@mediatek.com, deren.wu@mediatek.com,
chui-hao.chiu@mediatek.com, kuniyu@amazon.com,
romieu@fr.zoreil.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH net-next 7/7] wifi: mt76: move napi_enable() from under BH
Date: Wed, 22 Jan 2025 06:36:25 -0800 [thread overview]
Message-ID: <20250122063625.3ccac084@kernel.org> (raw)
In-Reply-To: <CANn89i+n4bpxUXMOiYdFa57SATCreum+XQAd8DtkLOFpic0a=A@mail.gmail.com>
On Wed, 22 Jan 2025 15:25:46 +0100 Eric Dumazet wrote:
> napi_schedule() can run from arbitrary contexts though...
>
> BH protection seems strange to me, but this is orthogonal to your fix.
Right, it doesn't need the BH "protection", it's just what we
do to make sure there is a softirq hook point after we call it.
Since local_irq_restore() does not call softirqs.
I didn't know how to express that in a way that would be understandable
for most :S
Thanks for catching the other bug!
prev parent reply other threads:[~2025-01-22 14:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-21 22:15 [PATCH net-next 0/7] eth: fix calling napi_enable() in atomic context Jakub Kicinski
2025-01-21 22:15 ` [PATCH net-next 1/7] eth: tg3: " Jakub Kicinski
2025-01-21 23:06 ` Michael Chan
2025-01-21 23:49 ` Jakub Kicinski
2025-01-22 7:41 ` Michael Chan
2025-01-22 14:27 ` Jakub Kicinski
2025-01-22 23:48 ` Jakub Kicinski
2025-01-23 10:48 ` Simon Horman
2025-01-22 14:10 ` Eric Dumazet
2025-01-21 22:15 ` [PATCH net-next 2/7] eth: forcedeth: remove local wrappers for napi enable/disable Jakub Kicinski
2025-01-22 8:40 ` Zhu Logan
2025-01-22 13:46 ` Eric Dumazet
2025-01-21 22:15 ` [PATCH net-next 3/7] eth: forcedeth: fix calling napi_enable() in atomic context Jakub Kicinski
2025-01-22 8:42 ` Zhu Logan
2025-01-22 13:44 ` Eric Dumazet
2025-01-21 22:15 ` [PATCH net-next 4/7] eth: 8139too: " Jakub Kicinski
2025-01-22 14:12 ` Eric Dumazet
2025-01-21 22:15 ` [PATCH net-next 5/7] eth: niu: " Jakub Kicinski
2025-01-22 14:15 ` Eric Dumazet
2025-01-21 22:15 ` [PATCH net-next 6/7] eth: via-rhine: " Jakub Kicinski
2025-01-22 14:20 ` Eric Dumazet
2025-01-21 22:15 ` [PATCH net-next 7/7] wifi: mt76: move napi_enable() from under BH Jakub Kicinski
2025-01-22 14:25 ` Eric Dumazet
2025-01-22 14:36 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250122063625.3ccac084@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chui-hao.chiu@mediatek.com \
--cc=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=deren.wu@mediatek.com \
--cc=edumazet@google.com \
--cc=emmanuel.grumbach@intel.com \
--cc=horms@kernel.org \
--cc=johannes.berg@intel.com \
--cc=kuniyu@amazon.com \
--cc=kvalo@kernel.org \
--cc=leitao@debian.org \
--cc=leon.yen@mediatek.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=mingyen.hsieh@mediatek.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quan.zhou@mediatek.com \
--cc=romieu@fr.zoreil.com \
--cc=ryder.lee@mediatek.com \
--cc=sean.wang@mediatek.com \
--cc=shayne.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).