From: Simon Horman <horms@kernel.org>
To: Gui-Dong Han <2045gemini@gmail.com>
Cc: 3chas3@gmail.com, linux-atm-general@lists.sourceforge.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
baijiaju1990@gmail.com, kuba@kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] atm/fore200e: Fix possible data race in fore200e_open()
Date: Wed, 22 Jan 2025 09:46:25 +0000 [thread overview]
Message-ID: <20250122094625.GA385045@kernel.org> (raw)
In-Reply-To: <20250122023745.584995-1-2045gemini@gmail.com>
On Wed, Jan 22, 2025 at 02:37:45AM +0000, Gui-Dong Han wrote:
> Protect access to fore200e->available_cell_rate with rate_mtx lock to
> prevent potential data race.
>
> In this case, since the update depends on a prior read, a data race
> could lead to a wrong fore200e.available_cell_rate value.
>
> The field fore200e.available_cell_rate is generally protected by the lock
> fore200e.rate_mtx when accessed. In all other read and write cases, this
> field is consistently protected by the lock, except for this case and
> during initialization.
>
> This potential bug was detected by our experimental static analysis tool,
> which analyzes locking APIs and paired functions to identify data races
> and atomicity violations.
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Cc: stable@vger.kernel.org
> Signed-off-by: Gui-Dong Han <2045gemini@gmail.com>
> ---
> v2:
> * Added a description of the data race hazard in fore200e_open(), as
> suggested by Jakub Kicinski and Simon Horman.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-01-22 9:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-22 2:37 [PATCH v2] atm/fore200e: Fix possible data race in fore200e_open() Gui-Dong Han
2025-01-22 9:46 ` Simon Horman [this message]
2025-01-23 15:12 ` Jakub Kicinski
2025-01-24 0:50 ` Gui-Dong Han
2025-11-11 12:47 ` Gui-Dong Han
2025-11-14 12:05 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250122094625.GA385045@kernel.org \
--to=horms@kernel.org \
--cc=2045gemini@gmail.com \
--cc=3chas3@gmail.com \
--cc=baijiaju1990@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).