[PATCH net v2] net: the appletalk subsystem no longer uses ndo_do_ioctl

[PATCH net v2] net: the appletalk subsystem no longer uses ndo_do_ioctl

[Yeking]

From: 谢致邦 (XIE Zhibang) <Yeking@Red54.com>

ndo_do_ioctl is no longer used by the appletalk subsystem after commit
45bd1c5ba758 ("net: appletalk: Drop aarp_send_probe_phase1()").

Fixes: 45bd1c5ba758 ("net: appletalk: Drop aarp_send_probe_phase1()")
Signed-off-by: 谢致邦 (XIE Zhibang) <Yeking@Red54.com>
---
V1 -> V2: Add Fixes tag

 include/linux/netdevice.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 8da4c61f97b9..2a59034a5fa2 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -1085,8 +1085,8 @@ struct netdev_net_notifier {
  *
  * int (*ndo_do_ioctl)(struct net_device *dev, struct ifreq *ifr, int cmd);
  *	Old-style ioctl entry point. This is used internally by the
- *	appletalk and ieee802154 subsystems but is no longer called by
- *	the device ioctl handler.
+ *	ieee802154 subsystem but is no longer called by the device
+ *	ioctl handler.
  *
  * int (*ndo_siocbond)(struct net_device *dev, struct ifreq *ifr, int cmd);
  *	Used by the bonding driver for its device specific ioctls:
-- 
2.43.0

Re: [PATCH net v2] net: the appletalk subsystem no longer uses ndo_do_ioctl

[Simon Horman]

On Tue, Jan 21, 2025 at 03:38:47PM +0000, Yeking@Red54.com wrote:
> From: 谢致邦 (XIE Zhibang) <Yeking@Red54.com>
> 
> ndo_do_ioctl is no longer used by the appletalk subsystem after commit
> 45bd1c5ba758 ("net: appletalk: Drop aarp_send_probe_phase1()").
> 
> Fixes: 45bd1c5ba758 ("net: appletalk: Drop aarp_send_probe_phase1()")
> Signed-off-by: 谢致邦 (XIE Zhibang) <Yeking@Red54.com>
> ---
> V1 -> V2: Add Fixes tag

FWIIW, I don't think a documentation change qualifies as a fix, and thus
should not have a Fixes tag. And as a documentation change, with no runtime
effect, I'm ambivalent regarding this being net or net-next material.

In any case, the change looks correct to me.

Reviewed-by: Simon Horman <horms@kernel.org>