netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Michael Edwards <mkedwards@meta.com>
Cc: <netdev@vger.kernel.org>, <mkubecek@suse.cz>
Subject: Re: [PATCH] ethtool: Fix JSON output for IRQ coalescing
Date: Wed, 22 Jan 2025 15:13:44 -0800	[thread overview]
Message-ID: <20250122151344.03f55b59@kernel.org> (raw)
In-Reply-To: <20250122181153.2563289-1-mkedwards@meta.com>

On Wed, 22 Jan 2025 09:40:15 -0800 Michael Edwards wrote:
> This diff will change the first rx/tx pair to adaptive-{rx|tx} and
> the second pair to cqe-mode-{rx|tx} to match the keys used to set
> the corresponding settings.

This has been broken for 3.5 years, so I think we can assume the old
keys weren't used:

Reviewed-by: Jakub Kicinski <kuba@kernel.org>

  reply	other threads:[~2025-01-22 23:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-22  1:14 [PATCH] ethtool: Fix JSON output for IRQ coalescing Michael Edwards
2025-01-22  2:17 ` Jakub Kicinski
2025-01-22 17:40   ` Michael Edwards
2025-01-22 23:13     ` Jakub Kicinski [this message]
2025-01-23 10:12     ` Michal Kubecek
2025-01-23 11:30     ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250122151344.03f55b59@kernel.org \
    --to=kuba@kernel.org \
    --cc=mkedwards@meta.com \
    --cc=mkubecek@suse.cz \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).