From: Jakub Kicinski <kuba@kernel.org>
To: Huacai Chen <chenhuacai@kernel.org>
Cc: Qunqin Zhao <zhaoqunqin@loongson.cn>,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, si.yanteng@linux.dev, fancer.lancer@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: stmmac: dwmac-loongson: Add fix_soc_reset function
Date: Wed, 22 Jan 2025 19:44:55 -0800 [thread overview]
Message-ID: <20250122194455.764124ad@kernel.org> (raw)
In-Reply-To: <CAAhV-H6HDOvjr5sA3n+dUMTLm22_p9fAFaTgEUcrufR3XHrj9Q@mail.gmail.com>
On Wed, 22 Jan 2025 12:09:28 +0800 Huacai Chen wrote:
> Subject: Re: [PATCH] net: stmmac: dwmac-loongson: Add fix_soc_reset function
>
> On Wed, Jan 22, 2025 at 2:11 AM Jakub Kicinski <kuba@kernel.org> wrote:
> >
> > On Tue, 21 Jan 2025 17:29:37 +0800 Huacai Chen wrote:
> > > Hi, Qunqin,
> > >
> > > The patch itself looks good to me, but something can be improved.
> > > 1. The title can be "net: stmmac: dwmac-loongson: Add fix_soc_reset() callback"
> > > 2. You lack a "." at the end of the commit message.
> > > 3. Add a "Cc: stable@vger.kernel.org" because it is needed to backport
> > > to 6.12/6.13.
> >
> > Please don't top post.
> I know about inline replies, but in this case I agree with the code
> itself so I cannot reply after the code.
You're not trying hard enough. The message is Subject, body and code.
Reply in the place where the problem is or where the CC stable should
be added.
next prev parent reply other threads:[~2025-01-23 3:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-21 8:25 [PATCH] net: stmmac: dwmac-loongson: Add fix_soc_reset function Qunqin Zhao
2025-01-21 9:29 ` Huacai Chen
2025-01-21 13:47 ` Yanteng Si
2025-01-22 1:32 ` Qunqin Zhao
2025-01-21 18:11 ` Jakub Kicinski
2025-01-22 4:09 ` Huacai Chen
2025-01-23 3:44 ` Jakub Kicinski [this message]
2025-01-22 1:22 ` Qunqin Zhao
2025-01-21 13:41 ` Yanteng Si
2025-01-22 1:31 ` Qunqin Zhao
2025-01-22 8:53 ` Yanteng Si
2025-02-06 7:22 ` Qunqin Zhao
2025-02-06 8:36 ` Yanteng Si
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250122194455.764124ad@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=chenhuacai@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fancer.lancer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=si.yanteng@linux.dev \
--cc=zhaoqunqin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).