From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, pabeni@redhat.com,
andrew+netdev@lunn.ch, horms@kernel.org,
michael.chan@broadcom.com, pavan.chebbi@broadcom.com,
ap420073@gmail.com
Subject: Re: [PATCH net-next v2 5/7] net: ethtool: populate the default HDS params in the core
Date: Thu, 23 Jan 2025 08:22:37 -0800 [thread overview]
Message-ID: <20250123082237.27c5fc40@kernel.org> (raw)
In-Reply-To: <CANn89i+a_DfERsqHbi6Uu9uzCsN+wKh7WXr6Xh957Cs86ThS9A@mail.gmail.com>
On Thu, 23 Jan 2025 17:15:55 +0100 Eric Dumazet wrote:
> I am unsure how to fix this, should all callers to
> dev->ethtool_ops->get_ringparam()
> have to populate tcp_data_split and hds_thresh from dev->cfg,
> or would the following fix be enough ?
I think the comparison in nsim_get_ringparam() should look at dev->cfg.
If the used configuration (dev->cfg) is not set (UNKNOWN), our default
is ENABLED.
next prev parent reply other threads:[~2025-01-23 16:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-19 2:05 [PATCH net-next v2 0/7] net: ethtool: fixes for HDS threshold Jakub Kicinski
2025-01-19 2:05 ` [PATCH net-next v2 1/7] net: move HDS config from ethtool state Jakub Kicinski
2025-01-19 2:05 ` [PATCH net-next v2 2/7] net: ethtool: store netdev in a temp variable in ethnl_default_set_doit() Jakub Kicinski
2025-01-19 2:05 ` [PATCH net-next v2 3/7] net: provide pending ring configuration in net_device Jakub Kicinski
2025-01-19 2:05 ` [PATCH net-next v2 4/7] eth: bnxt: apply hds_thrs settings correctly Jakub Kicinski
2025-01-19 2:05 ` [PATCH net-next v2 5/7] net: ethtool: populate the default HDS params in the core Jakub Kicinski
2025-01-23 16:15 ` Eric Dumazet
2025-01-23 16:22 ` Jakub Kicinski [this message]
2025-01-23 16:32 ` Eric Dumazet
2025-01-19 2:05 ` [PATCH net-next v2 6/7] eth: bnxt: allocate enough buffer space to meet HDS threshold Jakub Kicinski
2025-01-19 2:05 ` [PATCH net-next v2 7/7] eth: bnxt: update header sizing defaults Jakub Kicinski
2025-01-19 5:14 ` [PATCH net-next v2 0/7] net: ethtool: fixes for HDS threshold Michael Chan
2025-01-20 20:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250123082237.27c5fc40@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=ap420073@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).