From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
andrew+netdev@lunn.ch, horms@kernel.org,
dan.carpenter@linaro.org, Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH net v3 0/7] eth: fix calling napi_enable() in atomic context
Date: Thu, 23 Jan 2025 19:18:34 -0800 [thread overview]
Message-ID: <20250124031841.1179756-1-kuba@kernel.org> (raw)
Dan has reported that I missed a lot of drivers which call napi_enable()
in atomic with the naive coccinelle search for spin locks:
https://lore.kernel.org/dcfd56bc-de32-4b11-9e19-d8bd1543745d@stanley.mountain
Fix them. Most of the fixes involve taking the netdev_lock()
before the spin lock. mt76 is special because we can just
move napi_enable() from the BH section.
All patches compile tested only.
v3:
- [patch 1] move the annotation
v2: https://lore.kernel.org/20250123004520.806855-1-kuba@kernel.org
- [patch 1] correct commit msg (can't sleep -> needs to sleep)
- [patch 1] add re-locking annotation to tg3_irq_quiesce()
- [patch 6] actually switch to napi_enable_locked()
- [patch 7] reword the commit msg slightly
v1: https://lore.kernel.org/20250121221519.392014-1-kuba@kernel.org
Jakub Kicinski (7):
eth: tg3: fix calling napi_enable() in atomic context
eth: forcedeth: remove local wrappers for napi enable/disable
eth: forcedeth: fix calling napi_enable() in atomic context
eth: 8139too: fix calling napi_enable() in atomic context
eth: niu: fix calling napi_enable() in atomic context
eth: via-rhine: fix calling napi_enable() in atomic context
wifi: mt76: move napi_enable() from under BH
drivers/net/ethernet/broadcom/tg3.c | 35 ++++++++++++++++---
drivers/net/ethernet/nvidia/forcedeth.c | 32 ++++++-----------
drivers/net/ethernet/realtek/8139too.c | 4 ++-
drivers/net/ethernet/sun/niu.c | 10 +++++-
drivers/net/ethernet/via/via-rhine.c | 11 +++++-
.../net/wireless/mediatek/mt76/mt7603/mac.c | 9 +++--
.../net/wireless/mediatek/mt76/mt7615/pci.c | 8 +++--
.../wireless/mediatek/mt76/mt7615/pci_mac.c | 8 +++--
.../net/wireless/mediatek/mt76/mt76x0/pci.c | 8 +++--
.../net/wireless/mediatek/mt76/mt76x02_mmio.c | 8 +++--
.../net/wireless/mediatek/mt76/mt76x2/pci.c | 7 ++--
.../net/wireless/mediatek/mt76/mt7915/mac.c | 17 ++++++---
.../net/wireless/mediatek/mt76/mt7921/pci.c | 7 ++--
.../wireless/mediatek/mt76/mt7921/pci_mac.c | 7 ++--
.../net/wireless/mediatek/mt76/mt7925/pci.c | 7 ++--
.../wireless/mediatek/mt76/mt7925/pci_mac.c | 7 ++--
.../net/wireless/mediatek/mt76/mt7996/mac.c | 12 +++----
17 files changed, 132 insertions(+), 65 deletions(-)
--
2.48.1
next reply other threads:[~2025-01-24 3:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-24 3:18 Jakub Kicinski [this message]
2025-01-24 3:18 ` [PATCH net v3 1/7] eth: tg3: fix calling napi_enable() in atomic context Jakub Kicinski
2025-01-24 3:18 ` [PATCH net v3 2/7] eth: forcedeth: remove local wrappers for napi enable/disable Jakub Kicinski
2025-01-24 3:18 ` [PATCH net v3 3/7] eth: forcedeth: fix calling napi_enable() in atomic context Jakub Kicinski
2025-01-24 3:18 ` [PATCH net v3 4/7] eth: 8139too: " Jakub Kicinski
2025-01-24 3:18 ` [PATCH net v3 5/7] eth: niu: " Jakub Kicinski
2025-01-24 3:18 ` [PATCH net v3 6/7] eth: via-rhine: " Jakub Kicinski
2025-01-24 3:18 ` [PATCH net v3 7/7] wifi: mt76: move napi_enable() from under BH Jakub Kicinski
2025-01-27 22:40 ` [PATCH net v3 0/7] eth: fix calling napi_enable() in atomic context patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250124031841.1179756-1-kuba@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).