From: Jakub Kicinski <kuba@kernel.org>
To: Cosmin Ratiu <cratiu@nvidia.com>
Cc: "andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
"liuhangbin@gmail.com" <liuhangbin@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>,
Tariq Toukan <tariqt@nvidia.com>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
"razor@blackwall.org" <razor@blackwall.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"liali@redhat.com" <liali@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"jv@jvosburgh.net" <jv@jvosburgh.net>,
"edumazet@google.com" <edumazet@google.com>,
"horms@kernel.org" <horms@kernel.org>,
Jianbo Liu <jianbol@nvidia.com>,
Boris Pismenny <borisp@nvidia.com>
Subject: Re: [PATCHv2 net] Bonding: Fix support for gso_partial_features
Date: Fri, 24 Jan 2025 17:47:02 -0800 [thread overview]
Message-ID: <20250124174702.59c4b16b@kernel.org> (raw)
In-Reply-To: <b702b3c1caaa913905009296fa82e36fae264691.camel@nvidia.com>
On Fri, 24 Jan 2025 16:03:32 +0000 Cosmin Ratiu wrote:
> On Fri, 2025-01-24 at 07:38 -0800, Jakub Kicinski wrote:
> > On Thu, 23 Jan 2025 15:24:37 +0000 Cosmin Ratiu wrote:
> > > I've sent another patch to suggest these changes.
> >
> > FTR this is not the normal way to proceed in code review,
> > please try to share your feedback rather than taking over
> > the submission (unless the original author explicitly asks
> > you to).
>
> Apologies, I didn't want to take over the submission, both me and
> Hangbin were simultaneously looking to fix this issue. I was about to
> send my fix when I saw his proposed one (this thread) and in the
> interest of expediting the solution, I decided to send mine in addition
> to commenting here.
>
> Given that we were both fixing the same thing, would adding Signed-off-
> by with both of us be ok?
That's up to you, but keep in mind for the future that the discussion
on how to proceed has to happen before you post your own version.
prev parent reply other threads:[~2025-01-25 1:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-22 13:52 [PATCHv2 net] Bonding: Fix support for gso_partial_features Hangbin Liu
2025-01-23 12:15 ` Cosmin Ratiu
2025-01-23 15:24 ` Cosmin Ratiu
2025-01-24 15:38 ` Jakub Kicinski
2025-01-24 16:03 ` Cosmin Ratiu
2025-01-25 1:47 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250124174702.59c4b16b@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=borisp@nvidia.com \
--cc=cratiu@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jianbol@nvidia.com \
--cc=jv@jvosburgh.net \
--cc=liali@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).