[PATCH 1/2] net: usb: qmi_wwan: fix init for Wistron NeWeb M18QW

[PATCH 1/2] net: usb: qmi_wwan: fix init for Wistron NeWeb M18QW

[U Michel]

From: U M <ulv@on2.de>

fixed the initialization of the Wistron NeWeb M18QW. Successfully tested 
on a ZyXEL LTE3302 containing this modem.

Signed-off-by: U M <ulv@on2.de>
---
 drivers/net/usb/qmi_wwan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index e9208a8d2bfa..6c90685af771 100644
--- a/drivers/net/usb/qmi_wwan.c
+++ b/drivers/net/usb/qmi_wwan.c
@@ -1227,7 +1227,7 @@ static const struct usb_device_id products[] = {
 	{QMI_FIXED_INTF(0x1435, 0x0918, 3)},	/* Wistron NeWeb D16Q1 */
 	{QMI_FIXED_INTF(0x1435, 0x0918, 4)},	/* Wistron NeWeb D16Q1 */
 	{QMI_FIXED_INTF(0x1435, 0x0918, 5)},	/* Wistron NeWeb D16Q1 */
-	{QMI_FIXED_INTF(0x1435, 0x3185, 4)},	/* Wistron NeWeb M18Q5 */
+	{QMI_QUIRK_SET_DTR(0x1435, 0x3185, 4)},	/* Wistron NeWeb M18Q5 */
 	{QMI_FIXED_INTF(0x1435, 0xd111, 4)},	/* M9615A DM11-1 D51QC */
 	{QMI_FIXED_INTF(0x1435, 0xd181, 3)},	/* Wistron NeWeb D18Q1 */
 	{QMI_FIXED_INTF(0x1435, 0xd181, 4)},	/* Wistron NeWeb D18Q1 */
-- 
2.34.1

Re: [PATCH 1/2] net: usb: qmi_wwan: fix init for Wistron NeWeb M18QW

[Greg KH]

On Sat, Jan 25, 2025 at 10:37:45AM +0100, U Michel wrote:
> From: U M <ulv@on2.de>
> 
> fixed the initialization of the Wistron NeWeb M18QW. Successfully tested 
> on a ZyXEL LTE3302 containing this modem.
> 
> Signed-off-by: U M <ulv@on2.de>

Sorry, but we need a bit more of a name here other than just 2 initials
:(

thanks,

greg k-h

AW: [PATCH 1/2] net: usb: qmi_wwan: fix init for Wistron NeWeb M18QW

[Ulv Michel]

Sorry Greg KH,

Sorry, there seems to be a misconfiguration on my build machine...
The full name is Ulv Michel.

Thanks,
Ulv

-----Ursprüngliche Nachricht-----
Von: Greg KH <gregkh@linuxfoundation.org> 
Gesendet: Samstag, 25. Januar 2025 11:06
An: Ulv Michel <ulv@on2.de>
Cc: Bjørn Mork <bjorn@mork.no>; Andrew Lunn <andrew+netdev@lunn.ch>; David S . Miller <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; netdev@vger.kernel.org; linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org
Betreff: Re: [PATCH 1/2] net: usb: qmi_wwan: fix init for Wistron NeWeb M18QW

On Sat, Jan 25, 2025 at 10:37:45AM +0100, U Michel wrote:
> From: U M <ulv@on2.de>
> 
> fixed the initialization of the Wistron NeWeb M18QW. Successfully 
> tested on a ZyXEL LTE3302 containing this modem.
> 
> Signed-off-by: U M <ulv@on2.de>

Sorry, but we need a bit more of a name here other than just 2 initials :(

thanks,

greg k-h