From: Jakub Kicinski <kuba@kernel.org>
To: Matthieu Baerts <matttbe@kernel.org>, Jan Stancek <jstancek@redhat.com>
Cc: pshelar@ovn.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, liuhangbin@gmail.com,
linux-kselftest@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net] selftests: net/{lib,openvswitch}: extend CFLAGS to keep options from environment
Date: Mon, 27 Jan 2025 15:04:06 -0800 [thread overview]
Message-ID: <20250127150406.0d97a181@kernel.org> (raw)
In-Reply-To: <26ad0900-bd9d-464e-be9f-c1806b96c971@kernel.org>
On Thu, 23 Jan 2025 13:51:27 +0100 Matthieu Baerts wrote:
> > -CFLAGS = -Wall -Wl,--no-as-needed -O2 -g
> > +CFLAGS += -Wall -Wl,--no-as-needed -O2 -g
>
> (small detail: I guess the double whitespaces after the '=' were there
> to keep the alignment with the next line, so probably there should be
> only one now, but I don't think this alone is enough to ask for a v2!)
Adjusted when applying in both patches, so the bot will probably not
respond.
Thanks for these fixes!
prev parent reply other threads:[~2025-01-27 23:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-23 12:38 [PATCH net] selftests: net/{lib,openvswitch}: extend CFLAGS to keep options from environment Jan Stancek
2025-01-23 12:51 ` Matthieu Baerts
2025-01-26 2:03 ` Hangbin Liu
2025-01-27 14:50 ` Matthieu Baerts
2025-01-27 23:04 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250127150406.0d97a181@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jstancek@redhat.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=matttbe@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pshelar@ovn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).