netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Pedro Tammela <pctammela@mojatatu.com>
Cc: Cong Wang <xiyou.wangcong@gmail.com>,
	netdev@vger.kernel.org, jhs@mojatatu.com, jiri@resnulli.us,
	quanglex97@gmail.com, mincho@theori.io,
	Cong Wang <cong.wang@bytedance.com>
Subject: Re: [Patch net v2 2/4] selftests/tc-testing: Add a test case for pfifo_head_drop qdisc when limit==0
Date: Tue, 28 Jan 2025 14:00:11 -0800	[thread overview]
Message-ID: <20250128140011.221f4712@kernel.org> (raw)
In-Reply-To: <CAM_iQpXDtMngE1Pcf9KBmRpb5sZK4EJj6qgPgt1ioYW4QC9W3g@mail.gmail.com>

On Mon, 27 Jan 2025 20:25:09 -0800 Cong Wang wrote:
> > > Same problem as on v1:
> > >
> > > # Could not match regex pattern. Verify command output:
> > > # qdisc pfifo_head_drop 1: root refcnt 2 limit 0p
> > > #  Sent 0 bytes 0 pkt (dropped 0, overlimits 0 requeues 0)
> > > #  backlog 0b 0p requeues 0
> > >
> > > https://github.com/p4tc-dev/tc-executor/blob/storage/artifacts/966506/1-tdc-sh/stdout
> > >
> > > Did you run the full suite? I wonder if some other test leaks an
> > > interface with a 10.x network.  
> >
> > No, I only ran the tests shown above, I will run all the TDC tests.  
> 
> Hmm, I just got another error which prevents me from starting all the tests:
> 
> # -----> prepare stage *** Could not execute: "$TC qdisc replace dev
> $ETH handle 8001: parent root stab overhead 24 taprio num_tc 8 map 0 1
> 2 3 4 5 6 7 queues 1@0 1@1 1@2 1@3 1@4 1@5 1@6 1@7 base-time 0
> sched-entry S ff 20000000 flags 0x2"
> #
> # -----> prepare stage *** Error message: "Error: Device does not have
> a PTP clock.
> # "
> #
> # -----> prepare stage *** Aborting test run.
> 
> Let me see if I can workaround it before looking into it.

CC Pedro, in case he has cycles to take a look.

  reply	other threads:[~2025-01-28 22:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-26  4:12 [Patch net v2 0/4] net_sched: two security bug fixes and test cases Cong Wang
2025-01-26  4:12 ` [Patch net v2 1/4] pfifo_tail_enqueue: Drop new packet when sch->limit == 0 Cong Wang
2025-01-26  4:12 ` [Patch net v2 2/4] selftests/tc-testing: Add a test case for pfifo_head_drop qdisc when limit==0 Cong Wang
2025-01-27 16:57   ` Jakub Kicinski
2025-01-28  1:08     ` Cong Wang
2025-01-28  4:25       ` Cong Wang
2025-01-28 22:00         ` Jakub Kicinski [this message]
2025-01-28 23:19   ` Pedro Tammela
2025-01-31 23:13     ` Cong Wang
2025-01-26  4:12 ` [Patch net v2 3/4] netem: update sch->q.qlen before qdisc_tree_reduce_backlog() Cong Wang
2025-01-26  4:12 ` [Patch net v2 4/4] selftests/tc-testing: add a test case for qdisc_tree_reduce_backlog() Cong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250128140011.221f4712@kernel.org \
    --to=kuba@kernel.org \
    --cc=cong.wang@bytedance.com \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=mincho@theori.io \
    --cc=netdev@vger.kernel.org \
    --cc=pctammela@mojatatu.com \
    --cc=quanglex97@gmail.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).