From: Jakub Kicinski <kuba@kernel.org>
To: Justin Iurman <justin.iurman@uliege.be>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
dsahern@kernel.org, Tom Herbert <tom@herbertland.com>
Subject: Re: [PATCH net 1/2] net: ipv6: fix dst refleaks in rpl, seg6 and ioam6 lwtunnels
Date: Wed, 29 Jan 2025 12:23:32 -0800 [thread overview]
Message-ID: <20250129122332.20b6b172@kernel.org> (raw)
In-Reply-To: <d4cb495d-6549-4b5a-bcf4-38dbbdda202e@uliege.be>
On Wed, 29 Jan 2025 17:17:28 +0100 Justin Iurman wrote:
> > net/ipv6/ioam6_iptunnel.c | 5 +++--
> > net/ipv6/rpl_iptunnel.c | 6 ++++--
> > net/ipv6/seg6_iptunnel.c | 6 ++++--
> > 3 files changed, 11 insertions(+), 6 deletions(-)
>
> I think both ila_output() and tipc_udp_xmit() should also be patched
> accordingly. Other users seem fine.
TIPC is not a lwt, the cache belongs to a socket not another dst,
AFAICT.
I think in ILA ilwt->connected will only be set if we re-routed
the traffic to the real address already? So the dst can't match.
CC: Tom, full patch:
https://lore.kernel.org/all/20250129021346.2333089-2-kuba@kernel.org/
next prev parent reply other threads:[~2025-01-29 20:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-29 2:13 [PATCH net 1/2] net: ipv6: fix dst refleaks in rpl, seg6 and ioam6 lwtunnels Jakub Kicinski
2025-01-29 2:13 ` [PATCH net 2/2] net: ipv6: fix dst ref loops " Jakub Kicinski
2025-01-29 16:50 ` Justin Iurman
2025-01-29 20:14 ` Jakub Kicinski
2025-01-30 0:24 ` Justin Iurman
2025-01-29 16:10 ` [PATCH net 1/2] net: ipv6: fix dst refleaks " Justin Iurman
2025-01-29 16:17 ` Justin Iurman
2025-01-29 20:23 ` Jakub Kicinski [this message]
2025-01-30 0:16 ` Justin Iurman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250129122332.20b6b172@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=justin.iurman@uliege.be \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).