From: Jakub Kicinski <kuba@kernel.org>
To: Abdullah <asharji1828@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
skhan@linuxfoundation.org, davem@davemloft.net,
dsahern@kernel.org, edumazet@google.com, horms@kernel.org,
pabeni@redhat.com, syzkaller-bugs@googlegroups.com,
syzbot+5cfae50c0e5f2c500013@syzkaller.appspotmail.com
Subject: Re: [PATCH v3] net: ipmr: Fix out-of-bounds access i mr_mfc_uses_dev()
Date: Wed, 29 Jan 2025 16:56:31 -0800 [thread overview]
Message-ID: <20250129165631.50e9e58d@kernel.org> (raw)
In-Reply-To: <20250129085017.55991-1-asharji1828@gmail.com>
On Wed, 29 Jan 2025 12:50:17 +0400 Abdullah wrote:
> The issue was reported by Syzbot as an out-of-bounds read:
> UBSAN: array-index-out-of-bounds in net/ipv4/ipmr_base.c:289:10
> Index -772737152 is out of range for type 'const struct vif_device[32]'
>
> The problem occurs when the minvif/maxvif values in the mr_mfc struct
> become invalid (possibly due to memory corruption or uninitialized values).
> This patch fixes the issue by ensuring proper boundary checks and rcu_read
> locking before accessing vif_table[] in mr_mfc_uses_dev().
>
> Fixes: <COMMIT_HASH>
> Reported-by: syzbot+5cfae50c0e5f2c500013@syzkaller.appspotmail.com
> Signed-off-by: Abdullah <asharji1828@gmail.com>
Could you explain what you're trying to do here?
Are you just tossing patches to test at syzbot? If yes, please remove
the unnecessary CCs, reply directly to the syzbot address, there is no
need to spam the mailing lists.
Or do you mean this as a real submissions? In which case why is there
<COMMIT_HASH> instead of the correct commit? The entire submission
feels a little.. LLM-aided.
--
pw-bot: cr
prev parent reply other threads:[~2025-01-30 0:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-21 18:09 [syzbot] [net?] UBSAN: array-index-out-of-bounds in mr_table_dump syzbot
2025-01-29 8:26 ` [PATCH] net: ipmr: Fix out-of-bounds access in mr_mfc_uses_dev() Abdullah
2025-01-29 8:43 ` [PATCH v2] " Abdullah
2025-01-29 8:50 ` [PATCH v3] net: ipmr: Fix out-of-bounds access i mr_mfc_uses_dev() Abdullah
2025-01-30 0:56 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250129165631.50e9e58d@kernel.org \
--to=kuba@kernel.org \
--cc=asharji1828@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=skhan@linuxfoundation.org \
--cc=syzbot+5cfae50c0e5f2c500013@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).