netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netdev@vger.kernel.org, fw@strlen.de, netfilter-devel@vger.kernel.org
Subject: Re: [TEST] nft-flowtable-sh flaking after pulling first chunk of the merge window
Date: Wed, 29 Jan 2025 17:00:57 -0800	[thread overview]
Message-ID: <20250129170057.77738677@kernel.org> (raw)
In-Reply-To: <Z5oPNA0IFd7-zBts@calendula>

On Wed, 29 Jan 2025 12:21:24 +0100 Pablo Neira Ayuso wrote:
> > Could be very bad luck but after we fast forwarded net-next yesterday
> > we have 3 failures in less than 24h in nft_flowtabl.sh:
> > 
> > https://netdev.bots.linux.dev/contest.html?test=nft-flowtable-sh
> > 
> > # FAIL: flow offload for ns1/ns2 with masquerade and pmtu discovery : original counter  2113852 exceeds expected value 2097152, reply counter  60
> > https://netdev-3.bots.linux.dev/vmksft-nf/results/960740/11-nft-flowtable-sh/stdout
> > 
> > # FAIL: flow offload for ns1/ns2 with masquerade and pmtu discovery : original counter  3530493 exceeds expected value 3478585, reply counter  60
> > https://netdev-3.bots.linux.dev/vmksft-nf/results/960022/10-nft-flowtable-sh/stdout  
> 
> this is reporting a flow in forward chain going over the size of the
> file, this is a flow that is not follow flowtable path.
> 
> > # FAIL: dscp counters do not match, expected dscp3 and dscp0 > 0 but got  1431 , 0 
> > https://netdev-3.bots.linux.dev/vmksft-nf/results/960740/11-nft-flowtable-sh-retry/stdout  
> 
> this is reporting that occasionally a flow does not follow flowtable
> path, dscp3 gets bumped from the forward chain.
> 
> I can rarely see this last dscp tests FAIL when running this test in a
> loop here.
> 
> Just a follow up, I am still diagnosing.

Thanks for the update!

FWIW we hit 4 more flakes since I reported it to you last week
(first link from previous message will take you to them).
All four in dscp_fwd

  reply	other threads:[~2025-01-30  1:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-23 16:04 [TEST] nft-flowtable-sh flaking after pulling first chunk of the merge window Jakub Kicinski
2025-01-23 17:10 ` Pablo Neira Ayuso
2025-01-29 11:21 ` Pablo Neira Ayuso
2025-01-30  1:00   ` Jakub Kicinski [this message]
2025-02-05 23:20     ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250129170057.77738677@kernel.org \
    --to=kuba@kernel.org \
    --cc=fw@strlen.de \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).