From: Jakub Kicinski <kuba@kernel.org>
To: Justin Iurman <justin.iurman@uliege.be>
Cc: Paolo Abeni <pabeni@redhat.com>,
davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
andrew+netdev@lunn.ch, horms@kernel.org, dsahern@kernel.org
Subject: Re: [PATCH net v2 2/2] net: ipv6: fix dst ref loops in rpl, seg6 and ioam6 lwtunnels
Date: Thu, 30 Jan 2025 06:55:18 -0800 [thread overview]
Message-ID: <20250130065518.5872bbfa@kernel.org> (raw)
In-Reply-To: <cc9dd246-e8f8-4d10-9ca1-c7fed44ecde6@uliege.be>
On Thu, 30 Jan 2025 14:52:14 +0100 Justin Iurman wrote:
> > On 1/30/25 4:15 AM, Jakub Kicinski wrote:
> >> Some lwtunnels have a dst cache for post-transformation dst.
> >> If the packet destination did not change we may end up recording
> >> a reference to the lwtunnel in its own cache, and the lwtunnel
> >> state will never be freed.
> >
> > The series LGTM, but I'm wondering if we can't have a similar loop for
> > input lwt?
>
> Hmmm, I think Paolo is right. At least, I don't see a reason why it
> wouldn't be correct. We should also take care of input lwt for both
> seg6_iptunnel and rpl_iptunnel (ioam6_iptunnel does not implement input).
Would you be able to take care of that? And perhaps add a selftest at
least for the looped cases?
next prev parent reply other threads:[~2025-01-30 14:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-30 3:15 [PATCH net v2 1/2] net: ipv6: fix dst refleaks in rpl, seg6 and ioam6 lwtunnels Jakub Kicinski
2025-01-30 3:15 ` [PATCH net v2 2/2] net: ipv6: fix dst ref loops " Jakub Kicinski
2025-01-30 10:28 ` Simon Horman
2025-01-30 13:41 ` Justin Iurman
2025-01-30 14:56 ` Jakub Kicinski
2025-01-30 15:35 ` Simon Horman
2025-01-30 11:34 ` Paolo Abeni
2025-01-30 13:52 ` Justin Iurman
2025-01-30 14:55 ` Jakub Kicinski [this message]
2025-01-30 15:12 ` Justin Iurman
2025-01-30 16:53 ` Jakub Kicinski
2025-02-01 13:52 ` Justin Iurman
2025-02-02 0:56 ` Jakub Kicinski
2025-01-30 10:23 ` [PATCH net v2 1/2] net: ipv6: fix dst refleaks " Simon Horman
2025-02-02 1:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250130065518.5872bbfa@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=justin.iurman@uliege.be \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).