From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06FB31EE7D5 for ; Thu, 30 Jan 2025 16:24:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738254277; cv=none; b=OqIbNh6wBL0BlDQL/t0TEoec65hkzggKzDHBHmzrdd2XbddVXX+BXZs8eSpvpuQwFv/5sL9FTWlMoqB4wrtQMLfA2uuvsq8xprbYqmjxPgeOqMpYAYMye32Rmy1KjuU0DkKb3T6/fJubKG1y+9N4P0J1Le+xmVfW0jah++kacPU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738254277; c=relaxed/simple; bh=45G5j6oyDGlW8Bf+qvtfsv9vieDtBKtUR0HB4BhRBxc=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=poFNTt9mvizB+29zgiD2FzlMoComMR1/EdkvQqrb5+89+mMrEe2CY2wzTlhKpralx3Pu7904lVKIYipFL7FsO9iPy6Xbx3X6vr5CyllIiEJ5Ng+WAi3zk/nzifkNLWJvuTYwGcGidXs4tF/go+a71q7MQ38HHcTVzpE9FmwCPMQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kmj2fQC+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kmj2fQC+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2C653C4CEE0; Thu, 30 Jan 2025 16:24:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738254276; bh=45G5j6oyDGlW8Bf+qvtfsv9vieDtBKtUR0HB4BhRBxc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kmj2fQC+EwmNzC2b9w9McoY8oggeppih+eTnUesUqMuGnZpHWqxpLz8F/4mZXW7do w6Yi2UsOodKZaQdOg8fzNgBeqQqdYhR6QFIWQWlAJDfgPdL3s1HrR0hhP/HUbtMA0d 5n+6iLqphfRnStoe6jR9AeL78YyEnxh6n/0asomXW3I/sfeRHUTBsf3yZ6g89buyX7 VoKuCM0FiBjEWtC3FW6AjRajRmUKyNnhfeBEBHn05DwXuq1f/mD3qKDPmdvwm8cVaO ocWk32HA3bzHdanNtgEU4DDpF2PgqLBBaEYEoA2ktf6vHiJMcHGK6LaJ9RRXQTiv9U EILA0Jlau9Cyw== Date: Thu, 30 Jan 2025 08:24:35 -0800 From: Jakub Kicinski To: Danielle Ratson Cc: "netdev@vger.kernel.org" , "mkubecek@suse.cz" , "matt@traverse.com.au" , "daniel.zahka@gmail.com" , Amit Cohen , NBU-mlxsw Subject: Re: [PATCH ethtool-next 08/14] cmis: Enable JSON output support in CMIS modules Message-ID: <20250130082435.0a3a7922@kernel.org> In-Reply-To: References: <20250126115635.801935-1-danieller@nvidia.com> <20250126115635.801935-9-danieller@nvidia.com> <20250127121258.63f79e53@kernel.org> <20250128140923.144412cf@kernel.org> <20250129171728.1ad90a87@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 30 Jan 2025 12:38:56 +0000 Danielle Ratson wrote: > > > Yes, the unit is implied by the key is hardcoded. Same as for the > > > regular output, it should give the costumer idea about the scale. > > > There are also temperature fields that could be either F or C degrees. > > > So overall , the units fields should align all the fields that implies > > > some sort of scale. > > > > Some sort of a schema would be a better place to document the unit of the > > fields, IMO. > > So should the units fields be removed entirely? And only be > documented in the json schema file? Yes, more than happy to hear from others but a schema file would be my first choice. Short of that as long as the unit is the same as in the plain text output there should also not be any ambiguity.