From: Kory Maincent <kory.maincent@bootlin.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Donald Hunter <donald.hunter@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net 3/3] net: ethtool: tsconfig: Fix netlink type of hwtstamp flags
Date: Thu, 30 Jan 2025 10:27:16 +0100 [thread overview]
Message-ID: <20250130102716.3e15adb6@kmaincent-XPS-13-7390> (raw)
In-Reply-To: <20250129164907.6dd0b750@kernel.org>
On Wed, 29 Jan 2025 16:49:07 -0800
Jakub Kicinski <kuba@kernel.org> wrote:
> On Tue, 28 Jan 2025 16:35:48 +0100 Kory Maincent wrote:
> > Fix the netlink type for hardware timestamp flags, which are represented
> > as a bitset of flags. Although only one flag is supported currently, the
> > correct netlink bitset type should be used instead of u32. Address this
> > by adding a new named string set description for the hwtstamp flag
> > structure.
>
> Makes sense, please mention explicitly in the commit message that the
> code has been introduced in the current release so the uAPI change is
> still okay.
Ack.
> In general IMHO YNL makes the bitset functionality less important.
Do you mean you prefer u32 for bitfield instead of the bitset type? Why?
--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2025-01-30 9:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-28 15:35 [PATCH net 0/3] net: ethtool: timestamping: Fix small issues in the new uAPI Kory Maincent
2025-01-28 15:35 ` [PATCH net 1/3] MAINTAINERS: Add myself as maintainer for socket timestamping and expand file list Kory Maincent
2025-01-30 0:39 ` Jakub Kicinski
2025-01-30 9:18 ` Kory Maincent
2025-01-30 16:31 ` Jakub Kicinski
2025-01-30 16:56 ` Kory Maincent
2025-01-28 15:35 ` [PATCH net 2/3] net: ethtool: tsconfig: Fix ts filters and types enums size check Kory Maincent
2025-01-30 0:45 ` Jakub Kicinski
2025-01-30 9:24 ` Kory Maincent
2025-01-30 16:42 ` Jakub Kicinski
2025-01-28 15:35 ` [PATCH net 3/3] net: ethtool: tsconfig: Fix netlink type of hwtstamp flags Kory Maincent
2025-01-30 0:49 ` Jakub Kicinski
2025-01-30 9:27 ` Kory Maincent [this message]
2025-01-30 16:43 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250130102716.3e15adb6@kmaincent-XPS-13-7390 \
--to=kory.maincent@bootlin.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox