From: Simon Horman <horms@kernel.org>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: netdev@vger.kernel.org, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, nbd@nbd.name, sean.wang@mediatek.com,
ansuelsmth@gmail.com, upstream@airoha.com
Subject: Re: Move airoha in a dedicated folder
Date: Sat, 1 Feb 2025 15:50:09 +0000 [thread overview]
Message-ID: <20250201155009.GA211663@kernel.org> (raw)
In-Reply-To: <Z54XRR9DE7MIc0Sk@lore-desk>
On Sat, Feb 01, 2025 at 01:44:53PM +0100, Lorenzo Bianconi wrote:
> Hi all,
>
> Since more features are on the way for airoha_eth driver (support for flowtable
> hw offloading, 10g phy support, ..), I was wondering if it is neater to move
> the driver in a dedicated folder (e.g. drivers/net/ethernet/airoha or
> drivers/net/ethernet/mediatek/airoha) or if you prefer to keep current
> approach. Thanks.
<2c>
Hi Lorenzo,
There already seem drivers to be drivers under drivers/net/ethernet/mediatek/
which are built from more than once .c file. So I think it is fine
to leave Airoha's source there. But, OTOH, I do think it would
be neater to move it into it's own directory. Which is to say,
I for one am happy either way.
If you do chose to go for a new directory, I would suggest
drivers/net/ethernet/mediatek/airoha assuming as it is a Mediatek device.
</2c>
next prev parent reply other threads:[~2025-02-01 15:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-01 12:44 Move airoha in a dedicated folder Lorenzo Bianconi
2025-02-01 15:43 ` Andrew Lunn
2025-02-01 15:50 ` Simon Horman [this message]
2025-02-02 15:50 ` Christian Marangi (Ansuel)
2025-02-02 16:49 ` Andrew Lunn
2025-02-02 17:00 ` Christian Marangi (Ansuel)
2025-02-02 20:59 ` Lorenzo Bianconi
2025-02-04 9:37 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250201155009.GA211663@kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=lorenzo@kernel.org \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sean.wang@mediatek.com \
--cc=upstream@airoha.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).