netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: netdevsim: Support setting dev->perm_addr
Date: Mon, 3 Feb 2025 14:39:58 -0800	[thread overview]
Message-ID: <20250203143958.6172c5cd@kernel.org> (raw)
In-Reply-To: <20250203-netdevsim-perm_addr-v1-1-10084bc93044@redhat.com>

On Mon, 03 Feb 2025 18:21:24 +0100 Toke Høiland-Jørgensen wrote:
> Network management daemons that match on the device permanent address
> currently have no virtual interface types to test against.
> NetworkManager, in particular, has carried an out of tree patch to set
> the permanent address on netdevsim devices to use in its CI for this
> purpose.
> 
> To support this use case, add a debugfs file for netdevsim to set the
> permanent address to an arbitrary value.

netdevsim is not for user space testing. We have gone down the path
of supporting random features in it already, and then wasted time trying
to maintain them thru various devlink related perturbations, just to
find out that the features weren't actually used any more.

NetworkManager can do the HW testing using virtme-ng.

If you want to go down the netdevsim path you must provide a meaningful 
in-tree test, but let's be clear that we will 100% delete both the test
and the netdevsim functionality if it causes any issues.
-- 
pw-bot: cr

  reply	other threads:[~2025-02-03 22:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-03 17:21 [PATCH net-next] net: netdevsim: Support setting dev->perm_addr Toke Høiland-Jørgensen
2025-02-03 22:39 ` Jakub Kicinski [this message]
2025-02-03 23:04   ` Andrew Lunn
2025-02-04 10:30     ` Toke Høiland-Jørgensen
2025-02-04 11:20   ` Toke Høiland-Jørgensen
2025-02-04 16:56     ` Jakub Kicinski
2025-02-05  9:05       ` Toke Høiland-Jørgensen
2025-02-05 17:00         ` Jakub Kicinski
2025-02-05 17:08           ` Eric Dumazet
2025-02-05 19:13             ` Jakub Kicinski
2025-02-17 13:11 ` Jiri Pirko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250203143958.6172c5cd@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=toke@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).