From: Jakub Kicinski <kuba@kernel.org>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
andrew+netdev@lunn.ch, netdev@vger.kernel.org,
Michal Swiatkowski <michal.swiatkowski@linux.intel.com>,
sridhar.samudrala@intel.com, jacob.e.keller@intel.com,
pio.raczynski@gmail.com, konrad.knitter@intel.com,
marcin.szycik@intel.com, nex.sw.ncis.nat.hpm.dev@intel.com,
przemyslaw.kitszel@intel.com, jiri@resnulli.us, horms@kernel.org,
David.Laight@ACULAB.COM, pmenzel@molgen.mpg.de,
mschmidt@redhat.com, tatyana.e.nikolova@intel.com,
Jason Gunthorpe <jgg@ziepe.ca>, Leon Romanovsky <leon@kernel.org>,
linux-rdma@vger.kernel.org, corbet@lwn.net,
linux-doc@vger.kernel.org
Subject: Re: [PATCH net-next 2/9] ice: devlink PF MSI-X max and min parameter
Date: Tue, 4 Feb 2025 14:35:17 -0800 [thread overview]
Message-ID: <20250204143518.1583217e@kernel.org> (raw)
In-Reply-To: <20250203210940.328608-3-anthony.l.nguyen@intel.com>
On Mon, 3 Feb 2025 13:09:31 -0800 Tony Nguyen wrote:
> + if (val.vu32 > pf->hw.func_caps.common_cap.num_msix_vectors ||
> + val.vu32 < pf->msix.min) {
> + NL_SET_ERR_MSG_MOD(extack, "Value is invalid");
> + return -EINVAL;
> + if (val.vu32 < ICE_MIN_MSIX || val.vu32 > pf->msix.max) {
> + NL_SET_ERR_MSG_MOD(extack, "Value is invalid");
> + return -EINVAL;
Please follow up and either remove these extack messages, or make them
more meaningful. The "value is invalid" is already expressed by EINVAL
The suggestion to set the values at once or as "pending" is a
distraction IMO.
next prev parent reply other threads:[~2025-02-04 22:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-03 21:09 [PATCH net-next 0/9][pull request] ice: managing MSI-X in driver Tony Nguyen
2025-02-03 21:09 ` [PATCH net-next 1/9] ice: count combined queues using Rx/Tx count Tony Nguyen
2025-02-03 21:09 ` [PATCH net-next 2/9] ice: devlink PF MSI-X max and min parameter Tony Nguyen
2025-02-03 21:48 ` David Laight
2025-02-04 6:06 ` Michal Swiatkowski
2025-02-04 18:41 ` David Laight
2025-02-05 7:40 ` Michal Swiatkowski
2025-02-04 22:35 ` Jakub Kicinski [this message]
2025-02-05 5:46 ` Michal Swiatkowski
2025-02-03 21:09 ` [PATCH net-next 3/9] ice: remove splitting MSI-X between features Tony Nguyen
2025-02-03 21:09 ` [PATCH net-next 4/9] ice: get rid of num_lan_msix field Tony Nguyen
2025-02-03 21:09 ` [PATCH net-next 5/9] ice, irdma: move interrupts code to irdma Tony Nguyen
2025-02-03 21:09 ` [PATCH net-next 6/9] ice: treat dyn_allowed only as suggestion Tony Nguyen
2025-02-03 21:09 ` [PATCH net-next 7/9] ice: enable_rdma devlink param Tony Nguyen
2025-02-03 21:09 ` [PATCH net-next 8/9] ice: simplify VF MSI-X managing Tony Nguyen
2025-02-03 21:09 ` [PATCH net-next 9/9] ice: init flow director before RDMA Tony Nguyen
2025-02-04 22:42 ` [PATCH net-next 0/9][pull request] ice: managing MSI-X in driver Jakub Kicinski
2025-02-04 23:07 ` Tony Nguyen
2025-02-05 5:46 ` Michal Swiatkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250204143518.1583217e@kernel.org \
--to=kuba@kernel.org \
--cc=David.Laight@ACULAB.COM \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=jgg@ziepe.ca \
--cc=jiri@resnulli.us \
--cc=konrad.knitter@intel.com \
--cc=leon@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=marcin.szycik@intel.com \
--cc=michal.swiatkowski@linux.intel.com \
--cc=mschmidt@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nex.sw.ncis.nat.hpm.dev@intel.com \
--cc=pabeni@redhat.com \
--cc=pio.raczynski@gmail.com \
--cc=pmenzel@molgen.mpg.de \
--cc=przemyslaw.kitszel@intel.com \
--cc=sridhar.samudrala@intel.com \
--cc=tatyana.e.nikolova@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).