From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DFDB1FF7A5; Tue, 4 Feb 2025 22:35:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738708521; cv=none; b=lNqcWBQOPJHeAymmaJSrrOvi+nqakrM4nU8AJikKJr54EZUhhW/RYZMIK8LMOmNRyHlnzHKVBpUYBm0DFwxWwWKLWPPooC9mXIpyDRcX5cpnCr9b7K71Poq+Vow6YeBLcYTYMGVF+Nf8wfcWMBoU4zVsFHqUgVREkwwt02S6nfY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738708521; c=relaxed/simple; bh=mI2V72X0a2VUbi0NqJ8QzQBM8+pbwjo+YnbCECgSDWE=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=OYJZbWbwWu2CrztRu0m8q5Mfo2l+c8aNX9mI6pJzvfto8EVH8w9UvN3dUKuK92dBrcn8sBQDp3I01Gw5ncaKMUgXSd0UrIf/whxQ1TtmSOaeSgv1pBsqMTsQLa8z0WzYiP0oR19Ub5yddUTKQHDzKNlrl124ThjmSiaVQX8ibhk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YH6hCmsd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YH6hCmsd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1BF65C4CEDF; Tue, 4 Feb 2025 22:35:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738708520; bh=mI2V72X0a2VUbi0NqJ8QzQBM8+pbwjo+YnbCECgSDWE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=YH6hCmsdpAQfWAPW5Ur+F34mn54gGCp3aEsgO0mVmbKTUzIRvphrHqo/NHUs2KK// wljj3Mx/3bcyp9gYw9HJ4NV9TUPyUGa0/6WgEV1aGaT8McBi3GTw+WT4M0iJkVp9mV UE4ZdFnWvwVi2M6gqw1Hdy9YE+JMElkK8nuEku+SUjWb65laDWMaWTnwT6f5tp25u2 LmaDOzC27pWqrRjsyeM2U+m0RXjinG66HWshulbYMrl28+/UT3P4Cz6Gv9i+T4yC45 EJvO+vOLdna2t6Lx+1qh4BzZb/1TFJQl2jFdFxbT/CfbvqfD6982FFs8LOT6gYjDru eeA0CXhZpBHQQ== Date: Tue, 4 Feb 2025 14:35:17 -0800 From: Jakub Kicinski To: Tony Nguyen Cc: davem@davemloft.net, pabeni@redhat.com, edumazet@google.com, andrew+netdev@lunn.ch, netdev@vger.kernel.org, Michal Swiatkowski , sridhar.samudrala@intel.com, jacob.e.keller@intel.com, pio.raczynski@gmail.com, konrad.knitter@intel.com, marcin.szycik@intel.com, nex.sw.ncis.nat.hpm.dev@intel.com, przemyslaw.kitszel@intel.com, jiri@resnulli.us, horms@kernel.org, David.Laight@ACULAB.COM, pmenzel@molgen.mpg.de, mschmidt@redhat.com, tatyana.e.nikolova@intel.com, Jason Gunthorpe , Leon Romanovsky , linux-rdma@vger.kernel.org, corbet@lwn.net, linux-doc@vger.kernel.org Subject: Re: [PATCH net-next 2/9] ice: devlink PF MSI-X max and min parameter Message-ID: <20250204143518.1583217e@kernel.org> In-Reply-To: <20250203210940.328608-3-anthony.l.nguyen@intel.com> References: <20250203210940.328608-1-anthony.l.nguyen@intel.com> <20250203210940.328608-3-anthony.l.nguyen@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 3 Feb 2025 13:09:31 -0800 Tony Nguyen wrote: > + if (val.vu32 > pf->hw.func_caps.common_cap.num_msix_vectors || > + val.vu32 < pf->msix.min) { > + NL_SET_ERR_MSG_MOD(extack, "Value is invalid"); > + return -EINVAL; > + if (val.vu32 < ICE_MIN_MSIX || val.vu32 > pf->msix.max) { > + NL_SET_ERR_MSG_MOD(extack, "Value is invalid"); > + return -EINVAL; Please follow up and either remove these extack messages, or make them more meaningful. The "value is invalid" is already expressed by EINVAL The suggestion to set the values at once or as "pending" is a distraction IMO.