From: Simon Horman <horms@kernel.org>
To: Alexandra Winter <wintera@linux.ibm.com>
Cc: David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Aswin Karuvally <aswin@linux.ibm.com>,
netdev@vger.kernel.org, linux-s390@vger.kernel.org,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Thorsten Winkler <twinkler@linux.ibm.com>,
Jonathan Corbet <corbet@lwn.net>,
Peter Oberparleiter <oberpar@linux.ibm.com>
Subject: Re: [PATCH net-next] s390/net: Remove LCS driver
Date: Tue, 4 Feb 2025 14:39:38 +0000 [thread overview]
Message-ID: <20250204143938.GE234677@kernel.org> (raw)
In-Reply-To: <20250204103135.1619097-1-wintera@linux.ibm.com>
On Tue, Feb 04, 2025 at 11:31:35AM +0100, Alexandra Winter wrote:
> From: Aswin Karuvally <aswin@linux.ibm.com>
>
> The original Open Systems Adapter (OSA) was introduced by IBM in the
> mid-90s. These were then superseded by OSA-Express in 1999 which used
> Queued Direct IO to greatly improve throughput. The newer cards
> retained the older, slower non-QDIO (OSE) modes for compatibility with
> older systems. In Linux, the lcs driver was responsible for cards
> operating in the older OSE mode and the qeth driver was introduced to
> allow the OSA-Express cards to operate in the newer QDIO (OSD) mode.
>
> For an S390 machine from 1998 or later, there is no reason to use the
> OSE mode and lcs driver as all OSA cards since 1999 provide the faster
> OSD mode. As a result, it's been years since we have heard of a
> customer configuration involving the lcs driver.
>
> This patch removes the lcs driver. The technology it supports has been
> obsolete for past 25+ years and is irrelevant for current use cases.
>
> Reviewed-by: Alexandra Winter <wintera@linux.ibm.com>
> Acked-by: Heiko Carstens <hca@linux.ibm.com>
> Acked-by: Peter Oberparleiter <oberpar@linux.ibm.com>
> Signed-off-by: Aswin Karuvally <aswin@linux.ibm.com>
> Signed-off-by: Alexandra Winter <wintera@linux.ibm.com>
> ---
> Documentation/arch/s390/driver-model.rst | 2 +-
> arch/s390/include/asm/irq.h | 1 -
> arch/s390/kernel/irq.c | 1 -
> drivers/s390/net/Kconfig | 11 +-
> drivers/s390/net/Makefile | 1 -
> drivers/s390/net/lcs.c | 2385 ----------------------
> drivers/s390/net/lcs.h | 342 ----
> 7 files changed, 2 insertions(+), 2741 deletions(-)
> delete mode 100644 drivers/s390/net/lcs.c
> delete mode 100644 drivers/s390/net/lcs.h
Less is more :)
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-02-04 14:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-04 10:31 [PATCH net-next] s390/net: Remove LCS driver Alexandra Winter
2025-02-04 14:39 ` Simon Horman [this message]
2025-02-06 2:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250204143938.GE234677@kernel.org \
--to=horms@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=andrew+netdev@lunn.ch \
--cc=aswin@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oberpar@linux.ibm.com \
--cc=pabeni@redhat.com \
--cc=svens@linux.ibm.com \
--cc=twinkler@linux.ibm.com \
--cc=wintera@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).