From: Jonathan Cameron <jic23@kernel.org>
To: Michal Simek <michal.simek@amd.com>
Cc: <linux-kernel@vger.kernel.org>, <monstr@monstr.eu>,
<michal.simek@xilinx.com>, <git@xilinx.com>,
Anand Ashok Dumbre <anand.ashok.dumbre@xilinx.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
"Conor Dooley" <conor+dt@kernel.org>,
Damien Le Moal <dlemoal@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
Harini Katakam <harini.katakam@amd.com>,
Jakub Kicinski <kuba@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
Mark Brown <broonie@kernel.org>,
Michael Tretter <m.tretter@pengutronix.de>,
Michael Turquette <mturquette@baylibre.com>,
Mubin Sayyed <mubin.sayyed@amd.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Niklas Cassel <cassel@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh@kernel.org>,
Shyam Pandey <radhey.shyam.pandey@amd.com>,
Stephen Boyd <sboyd@kernel.org>, Vinod Koul <vkoul@kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM"
<dmaengine@vger.kernel.org>,
"moderated list:ARM/ZYNQ ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"open list:COMMON CLK FRAMEWORK" <linux-clk@vger.kernel.org>,
"open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)"
<linux-ide@vger.kernel.org>,
"open list:XILINX AMS DRIVER" <linux-iio@vger.kernel.org>,
"open list:SPI SUBSYSTEM" <linux-spi@vger.kernel.org>,
"open list:USB SUBSYSTEM" <linux-usb@vger.kernel.org>,
"open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>
Subject: Re: [PATCH 2/2] dt-bindings: xilinx: Deprecate header with firmware constants
Date: Tue, 4 Feb 2025 20:04:46 +0000 [thread overview]
Message-ID: <20250204200446.32bfb3f8@jic23-huawei> (raw)
In-Reply-To: <2a6f0229522327939e6893565e540b75f854a37b.1738600745.git.michal.simek@amd.com>
On Mon, 3 Feb 2025 17:39:11 +0100
Michal Simek <michal.simek@amd.com> wrote:
> Firmware contants do not fit the purpose of bindings because they are not
> independent IDs for abstractions. They are more or less just contants which
> better to wire via header with DT which is using it.
> That's why add deprecated message to dt binding header and also update
> existing dt bindings not to use macros from the header and replace them by
> it's value. Actually value is not relevant because it is only example.
>
> The similar changes have been done by commit 9d9292576810 ("dt-bindings:
> pinctrl: samsung: deprecate header with register constants").
>
> Signed-off-by: Michal Simek <michal.simek@amd.com>
For IIO
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
>
> Documentation/devicetree/bindings/ata/ceva,ahci-1v84.yaml | 4 +---
> .../bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml | 3 +--
> .../devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml | 3 +--
> Documentation/devicetree/bindings/net/cdns,macb.yaml | 7 +++----
> Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml | 3 +--
> Documentation/devicetree/bindings/usb/dwc3-xilinx.yaml | 3 +--
> include/dt-bindings/clock/xlnx-zynqmp-clk.h | 7 +++++++
> 7 files changed, 15 insertions(+), 15 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/ata/ceva,ahci-1v84.yaml b/Documentation/devicetree/bindings/ata/ceva,ahci-1v84.yaml
> index 9952e0ef7767..6ad78429dc74 100644
> --- a/Documentation/devicetree/bindings/ata/ceva,ahci-1v84.yaml
> +++ b/Documentation/devicetree/bindings/ata/ceva,ahci-1v84.yaml
> @@ -163,11 +163,9 @@ additionalProperties: false
>
> examples:
> - |
> - #include <dt-bindings/clock/xlnx-zynqmp-clk.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> #include <dt-bindings/power/xlnx-zynqmp-power.h>
> #include <dt-bindings/reset/xlnx-zynqmp-resets.h>
> - #include <dt-bindings/clock/xlnx-zynqmp-clk.h>
> #include <dt-bindings/phy/phy.h>
>
> sata: ahci@fd0c0000 {
> @@ -175,7 +173,7 @@ examples:
> reg = <0xfd0c0000 0x200>;
> interrupt-parent = <&gic>;
> interrupts = <0 133 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&zynqmp_clk SATA_REF>;
> + clocks = <&zynqmp_clk 22>;
> ceva,p0-cominit-params = /bits/ 8 <0x0F 0x25 0x18 0x29>;
> ceva,p0-comwake-params = /bits/ 8 <0x04 0x0B 0x08 0x0F>;
> ceva,p0-burst-params = /bits/ 8 <0x0A 0x08 0x4A 0x06>;
> diff --git a/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml b/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml
> index ac3198953b8e..b5399c65a731 100644
> --- a/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml
> +++ b/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dma-1.0.yaml
> @@ -75,7 +75,6 @@ additionalProperties: false
>
> examples:
> - |
> - #include <dt-bindings/clock/xlnx-zynqmp-clk.h>
>
> fpd_dma_chan1: dma-controller@fd500000 {
> compatible = "xlnx,zynqmp-dma-1.0";
> @@ -84,7 +83,7 @@ examples:
> interrupts = <0 117 0x4>;
> #dma-cells = <1>;
> clock-names = "clk_main", "clk_apb";
> - clocks = <&zynqmp_clk GDMA_REF>, <&zynqmp_clk LPD_LSBUS>;
> + clocks = <&zynqmp_clk 19>, <&zynqmp_clk 31>;
> xlnx,bus-width = <128>;
> dma-coherent;
> };
> diff --git a/Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml b/Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml
> index 8cbad7e792b6..a403392fb263 100644
> --- a/Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml
> @@ -193,7 +193,6 @@ additionalProperties: false
>
> examples:
> - |
> - #include <dt-bindings/clock/xlnx-zynqmp-clk.h>
>
> bus {
> #address-cells = <2>;
> @@ -204,7 +203,7 @@ examples:
> interrupt-parent = <&gic>;
> interrupts = <0 56 4>;
> reg = <0x0 0xffa50000 0x0 0x800>;
> - clocks = <&zynqmp_clk AMS_REF>;
> + clocks = <&zynqmp_clk 70>;
> #address-cells = <1>;
> #size-cells = <1>;
> #io-channel-cells = <1>;
> diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml
> index 3c30dd23cd4e..8d69846b2e09 100644
> --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml
> +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml
> @@ -197,7 +197,6 @@ examples:
> };
>
> - |
> - #include <dt-bindings/clock/xlnx-zynqmp-clk.h>
> #include <dt-bindings/power/xlnx-zynqmp-power.h>
> #include <dt-bindings/reset/xlnx-zynqmp-resets.h>
> #include <dt-bindings/phy/phy.h>
> @@ -210,9 +209,9 @@ examples:
> interrupt-parent = <&gic>;
> interrupts = <0 59 4>, <0 59 4>;
> reg = <0x0 0xff0c0000 0x0 0x1000>;
> - clocks = <&zynqmp_clk LPD_LSBUS>, <&zynqmp_clk GEM1_REF>,
> - <&zynqmp_clk GEM1_TX>, <&zynqmp_clk GEM1_RX>,
> - <&zynqmp_clk GEM_TSU>;
> + clocks = <&zynqmp_clk 31>, <&zynqmp_clk 105>,
> + <&zynqmp_clk 51>, <&zynqmp_clk 50>,
> + <&zynqmp_clk 44>;
> clock-names = "pclk", "hclk", "tx_clk", "rx_clk", "tsu_clk";
> #address-cells = <1>;
> #size-cells = <0>;
> diff --git a/Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml b/Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml
> index 04d4d3b4916d..02cf1314367b 100644
> --- a/Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml
> +++ b/Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml
> @@ -65,14 +65,13 @@ allOf:
>
> examples:
> - |
> - #include <dt-bindings/clock/xlnx-zynqmp-clk.h>
> soc {
> #address-cells = <2>;
> #size-cells = <2>;
>
> qspi: spi@ff0f0000 {
> compatible = "xlnx,zynqmp-qspi-1.0";
> - clocks = <&zynqmp_clk QSPI_REF>, <&zynqmp_clk LPD_LSBUS>;
> + clocks = <&zynqmp_clk 53>, <&zynqmp_clk 82>;
> clock-names = "ref_clk", "pclk";
> interrupts = <0 15 4>;
> interrupt-parent = <&gic>;
> diff --git a/Documentation/devicetree/bindings/usb/dwc3-xilinx.yaml b/Documentation/devicetree/bindings/usb/dwc3-xilinx.yaml
> index 00f87a558c7d..b5843f4d17d8 100644
> --- a/Documentation/devicetree/bindings/usb/dwc3-xilinx.yaml
> +++ b/Documentation/devicetree/bindings/usb/dwc3-xilinx.yaml
> @@ -101,7 +101,6 @@ examples:
> #include <dt-bindings/dma/xlnx-zynqmp-dpdma.h>
> #include <dt-bindings/power/xlnx-zynqmp-power.h>
> #include <dt-bindings/reset/xlnx-zynqmp-resets.h>
> - #include <dt-bindings/clock/xlnx-zynqmp-clk.h>
> #include <dt-bindings/reset/xlnx-zynqmp-resets.h>
> #include <dt-bindings/phy/phy.h>
> axi {
> @@ -113,7 +112,7 @@ examples:
> #size-cells = <0x2>;
> compatible = "xlnx,zynqmp-dwc3";
> reg = <0x0 0xff9d0000 0x0 0x100>;
> - clocks = <&zynqmp_clk USB0_BUS_REF>, <&zynqmp_clk USB3_DUAL_REF>;
> + clocks = <&zynqmp_clk 32>, <&zynqmp_clk 34>;
> clock-names = "bus_clk", "ref_clk";
> power-domains = <&zynqmp_firmware PD_USB_0>;
> resets = <&zynqmp_reset ZYNQMP_RESET_USB1_CORERESET>,
> diff --git a/include/dt-bindings/clock/xlnx-zynqmp-clk.h b/include/dt-bindings/clock/xlnx-zynqmp-clk.h
> index cdc4c0b9a374..f0f7ddd3dcbd 100644
> --- a/include/dt-bindings/clock/xlnx-zynqmp-clk.h
> +++ b/include/dt-bindings/clock/xlnx-zynqmp-clk.h
> @@ -9,6 +9,13 @@
> #ifndef _DT_BINDINGS_CLK_ZYNQMP_H
> #define _DT_BINDINGS_CLK_ZYNQMP_H
>
> +/*
> + * These bindings are deprecated, because they do not match the actual
> + * concept of bindings but rather contain pure firmware values.
> + * Instead include the header in the DTS source directory.
> + */
> +#warning "These bindings are deprecated. Instead use the header in the DTS source directory."
> +
> #define IOPLL 0
> #define RPLL 1
> #define APLL 2
next prev parent reply other threads:[~2025-02-04 20:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-03 16:39 [PATCH 0/2] arm64: zynqmp: Move firmware constants from binding to platform Michal Simek
2025-02-03 16:39 ` [PATCH 2/2] dt-bindings: xilinx: Deprecate header with firmware constants Michal Simek
2025-02-04 20:04 ` Jonathan Cameron [this message]
2025-02-18 10:54 ` Vinod Koul
2025-02-04 19:43 ` [PATCH 0/2] arm64: zynqmp: Move firmware constants from binding to platform Conor Dooley
2025-02-17 15:25 ` Michal Simek
2025-02-20 11:21 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250204200446.32bfb3f8@jic23-huawei \
--to=jic23@kernel.org \
--cc=anand.ashok.dumbre@xilinx.com \
--cc=andrew+netdev@lunn.ch \
--cc=broonie@kernel.org \
--cc=cassel@kernel.org \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dlemoal@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=edumazet@google.com \
--cc=git@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=harini.katakam@amd.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.tretter@pengutronix.de \
--cc=michal.simek@amd.com \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=mturquette@baylibre.com \
--cc=mubin.sayyed@amd.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=pabeni@redhat.com \
--cc=radhey.shyam.pandey@amd.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).