netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
	andrew+netdev@lunn.ch, horms@kernel.org, tariqt@nvidia.com,
	hawk@kernel.org, Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH net-next 2/4] eth: mlx4: don't try to complete XDP frames in netpoll
Date: Tue,  4 Feb 2025 19:12:11 -0800	[thread overview]
Message-ID: <20250205031213.358973-3-kuba@kernel.org> (raw)
In-Reply-To: <20250205031213.358973-1-kuba@kernel.org>

mlx4 doesn't support xdp xmit and wasn't using page pool
until now, so it could run XDP completions in netpoll
(NAPI budget == 0) just fine. Page pool has calling
context requirements, make sure we don't try to call
it from what is potentially HW IRQ context.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
 drivers/net/ethernet/mellanox/mlx4/en_tx.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/mellanox/mlx4/en_tx.c b/drivers/net/ethernet/mellanox/mlx4/en_tx.c
index 1ddb11cb25f9..6e077d202827 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_tx.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_tx.c
@@ -450,6 +450,8 @@ int mlx4_en_process_tx_cq(struct net_device *dev,
 
 	if (unlikely(!priv->port_up))
 		return 0;
+	if (unlikely(!napi_budget) && cq->type == TX_XDP)
+		return 0;
 
 	netdev_txq_bql_complete_prefetchw(ring->tx_queue);
 
-- 
2.48.1


  parent reply	other threads:[~2025-02-05  3:12 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-05  3:12 [PATCH net-next 0/4] eth: mlx4: use the page pool for Rx buffers Jakub Kicinski
2025-02-05  3:12 ` [PATCH net-next 1/4] eth: mlx4: create a page pool for Rx Jakub Kicinski
2025-02-06 19:44   ` Tariq Toukan
2025-02-06 23:04     ` Jakub Kicinski
2025-02-11 18:01       ` Tariq Toukan
2025-02-11 19:06         ` Jakub Kicinski
2025-02-11 19:11           ` Tariq Toukan
2025-02-11 19:21             ` Tariq Toukan
2025-02-11 19:23               ` Jakub Kicinski
2025-02-11 19:38                 ` Tariq Toukan
2025-02-11 19:18   ` Tariq Toukan
2025-02-11 19:44     ` Jakub Kicinski
2025-02-05  3:12 ` Jakub Kicinski [this message]
2025-02-06 19:50   ` [PATCH net-next 2/4] eth: mlx4: don't try to complete XDP frames in netpoll Tariq Toukan
2025-02-06 23:05     ` Jakub Kicinski
2025-02-05  3:12 ` [PATCH net-next 3/4] eth: mlx4: remove the local XDP fast-recycling ring Jakub Kicinski
2025-02-05  3:12 ` [PATCH net-next 4/4] eth: mlx4: use the page pool for Rx buffers Jakub Kicinski
2025-02-05 18:05   ` Ido Schimmel
2025-02-05 19:11     ` Jakub Kicinski
2025-02-06 12:57 ` [PATCH net-next 0/4] " Tariq Toukan
2025-02-06 15:58   ` Jakub Kicinski
2025-02-11 18:05     ` Tariq Toukan
2025-02-11 18:50       ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250205031213.358973-3-kuba@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hawk@kernel.org \
    --cc=horms@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).