From: Jakub Kicinski <kuba@kernel.org>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>
Cc: Eric Dumazet <edumazet@google.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: netdevsim: Support setting dev->perm_addr
Date: Wed, 5 Feb 2025 11:13:24 -0800 [thread overview]
Message-ID: <20250205111324.34db2521@kernel.org> (raw)
In-Reply-To: <CANn89iK8YpzNhJv4R+x80hcq794bh_ykS-O-2UHziBXixNhzyA@mail.gmail.com>
On Wed, 5 Feb 2025 18:08:00 +0100 Eric Dumazet wrote:
> > > Right. How do you feel about Andrew's suggestion of just setting a
> > > static perm_addr for netdevsim devices?
> >
> > I don't see how that'd be sufficient for a meaningful test.
>
> Perhaps allow IFLA_PERM_ADDRESS to be set at veth creation time,
> or other virtual devices...
I'd rather we didn't sprinkle testing code into real drivers, FWIW.
next prev parent reply other threads:[~2025-02-05 19:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-03 17:21 [PATCH net-next] net: netdevsim: Support setting dev->perm_addr Toke Høiland-Jørgensen
2025-02-03 22:39 ` Jakub Kicinski
2025-02-03 23:04 ` Andrew Lunn
2025-02-04 10:30 ` Toke Høiland-Jørgensen
2025-02-04 11:20 ` Toke Høiland-Jørgensen
2025-02-04 16:56 ` Jakub Kicinski
2025-02-05 9:05 ` Toke Høiland-Jørgensen
2025-02-05 17:00 ` Jakub Kicinski
2025-02-05 17:08 ` Eric Dumazet
2025-02-05 19:13 ` Jakub Kicinski [this message]
2025-02-17 13:11 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250205111324.34db2521@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).