From: Danielle Ratson <danieller@nvidia.com>
To: <netdev@vger.kernel.org>
Cc: <mkubecek@suse.cz>, <matt@traverse.com.au>,
<daniel.zahka@gmail.com>, <amcohen@nvidia.com>,
<nbu-mlxsw@exchange.nvidia.com>,
Danielle Ratson <danieller@nvidia.com>
Subject: [PATCH ethtool-next v4 00/16] Add JSON output to --module-info
Date: Wed, 5 Feb 2025 17:54:20 +0200 [thread overview]
Message-ID: <20250205155436.1276904-1-danieller@nvidia.com> (raw)
Add JSON output for 'ethtool -m' / --module-info, following the
guideline below:
1. Fields with description, will have a separate description field.
2. Units will be documented in a separate module-info.json file.
3. ASCII fields will be presented as strings.
4. On/Off is rendered as true/false.
5. Yes/no is rendered as true/false.
6. Per-channel fields will be presented as array, when each element
represents a channel.
7. Fields that hold version, will be split to major and minor sub
fields.
This patchset suppose to extend [1] to cover all types of modules.
Patchset overview:
Patches #1-#7: Preparations.
Patches #8-#9: Add JSON output support for CMIS compliant modules.
Patches #10-#11: Add JSON output support for SFF8636 modules.
Patches #12-#14: Add JSON output support for SFF8079 and SFF8472 modules.
Patch #15: Add a new schema JSON file for units documentation.
Patches #16: Add '-j' support to ethtool
[1] https://lore.kernel.org/all/20220704054114.22582-2-matt@traverse.com.au/
v4:
Patch #10:
* In extended_identifier field, use an array for all
descriptions instead of 3 different descriptions.
* Remove duplicated definition of YESNO() and ONOFF()
* defines.
v3:
* Remove unit fields from JSON output.
* Reword commit messages.
* Add patch #2 and #15.
* Enable properly JSON output support for SFF8079.
* Remove printings from fields that might be empty strings.
* Fix JSON output in sff8636_show_dom_mod_lvl_flags().
v2:
* In rx_power JSON field, add a type field to let the user know
what type is printed in "value".
* Use uint instead of hexa fields in JSON context.
* Simplify sff8636_show_dom().
* Use "false" in module_show_lane_status() instead of "None" in
JSON context.
module_common: Add a new file to all the common code for all module
types
ethtool: Standardize Link Length field names across module types
sff_common: Move sff_show_revision_compliance() to qsfp.c
cmis: Change loop order in cmis_show_dom_chan_lvl_flags()
qsfp: Reorder the channel-level flags list for SFF8636 module type
qsfp: Refactor sff8636_show_dom() by moving code into separate
functions
module_common: Add helpers to support JSON printing for common value
types
cmis: Add JSON output handling to --module-info in CMIS modules
cmis: Enable JSON output support in CMIS modules
qsfp: Add JSON output handling to --module-info in SFF8636 modules
qsfp: Enable JSON output support for SFF8636 modules
sfpid: Add JSON output handling to --module-info in SFF8079 modules
sfpdiag: Add JSON output handling to --module-info in SFF8472 modules
ethtool: Enable JSON output support for SFF8079 and SFF8472 modules
module_info: Add a new JSON file for units documentation
ethtool: Add '-j' support to ethtool
Makefile.am | 7 +-
cmis.c | 493 +++++++++++-----------
cmis.h | 65 ---
ethtool.c | 10 +-
module-common.c | 662 +++++++++++++++++++++++++++++
module-common.h | 287 +++++++++++++
module_info.json | 191 +++++++++
netlink/module-eeprom.c | 26 +-
qsfp.c | 894 +++++++++++++++++++++-------------------
qsfp.h | 108 -----
sff-common.c | 348 ++++------------
sff-common.h | 119 ++----
sfpdiag.c | 52 ++-
sfpid.c | 446 +++++++++++---------
14 files changed, 2250 insertions(+), 1458 deletions(-)
create mode 100644 module-common.c
create mode 100644 module-common.h
create mode 100644 module_info.json
--
2.47.0
next reply other threads:[~2025-02-05 15:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 15:54 Danielle Ratson [this message]
2025-02-05 15:54 ` [PATCH ethtool-next v4 01/16] module_common: Add a new file to all the common code for all module types Danielle Ratson
2025-02-05 15:54 ` [PATCH ethtool-next v4 02/16] ethtool: Standardize Link Length field names across " Danielle Ratson
2025-02-05 15:54 ` [PATCH ethtool-next v4 03/16] sff_common: Move sff_show_revision_compliance() to qsfp.c Danielle Ratson
2025-02-05 15:54 ` [PATCH ethtool-next v4 04/16] cmis: Change loop order in cmis_show_dom_chan_lvl_flags() Danielle Ratson
2025-02-05 15:54 ` [PATCH ethtool-next v4 05/16] qsfp: Reorder the channel-level flags list for SFF8636 module type Danielle Ratson
2025-02-05 15:54 ` [PATCH ethtool-next v4 06/16] qsfp: Refactor sff8636_show_dom() by moving code into separate functions Danielle Ratson
2025-02-05 15:54 ` [PATCH ethtool-next v4 07/16] module_common: Add helpers to support JSON printing for common value types Danielle Ratson
2025-02-05 15:54 ` [PATCH ethtool-next v4 08/16] cmis: Add JSON output handling to --module-info in CMIS modules Danielle Ratson
2025-02-05 15:54 ` [PATCH ethtool-next v4 09/16] cmis: Enable JSON output support " Danielle Ratson
2025-02-05 15:54 ` [PATCH ethtool-next v4 10/16] qsfp: Add JSON output handling to --module-info in SFF8636 modules Danielle Ratson
2025-02-05 15:54 ` [PATCH ethtool-next v4 11/16] qsfp: Enable JSON output support for " Danielle Ratson
2025-02-07 0:38 ` Jakub Kicinski
2025-02-05 15:54 ` [PATCH ethtool-next v4 12/16] sfpid: Add JSON output handling to --module-info in SFF8079 modules Danielle Ratson
2025-02-05 15:54 ` [PATCH ethtool-next v4 13/16] sfpdiag: Add JSON output handling to --module-info in SFF8472 modules Danielle Ratson
2025-02-05 15:54 ` [PATCH ethtool-next v4 14/16] ethtool: Enable JSON output support for SFF8079 and " Danielle Ratson
2025-02-05 15:54 ` [PATCH ethtool-next v4 15/16] module_info: Add a new JSON file for units documentation Danielle Ratson
2025-02-05 15:54 ` [PATCH ethtool-next v4 16/16] ethtool: Add '-j' support to ethtool Danielle Ratson
2025-02-07 0:39 ` [PATCH ethtool-next v4 00/16] Add JSON output to --module-info Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250205155436.1276904-1-danieller@nvidia.com \
--to=danieller@nvidia.com \
--cc=amcohen@nvidia.com \
--cc=daniel.zahka@gmail.com \
--cc=matt@traverse.com.au \
--cc=mkubecek@suse.cz \
--cc=nbu-mlxsw@exchange.nvidia.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).