From: Jakub Kicinski <kuba@kernel.org>
To: Mina Almasry <almasrymina@google.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org
Subject: Re: [PATCH net-next 2/3] net: devmem: don't call queue stop / start when the interface is down
Date: Wed, 5 Feb 2025 17:26:32 -0800 [thread overview]
Message-ID: <20250205172632.61f41a06@kernel.org> (raw)
In-Reply-To: <CAHS8izNgVd_bPDCiFD5mN=TgkcaKmQK1RcLgw_051GRHcLXHvw@mail.gmail.com>
On Wed, 5 Feb 2025 12:35:30 -0800 Mina Almasry wrote:
> Why not return an error if !netif_running(), and change the call site
> in net_devmem_unbind_dmabuf() to not call into this if
> !netif_running()? Is that a bit cleaner? It feels a bit weird to have
> netdev_rx_queue_restart() do a bunch of allocations and driver calls
> unnecessarily when it's really not going to do anything, no?
The bindings survive ifdown, right? So presumably they exist while
the device is down. If they exist while the device is down, why can
they not be created? Feels inconsistent.
next prev parent reply other threads:[~2025-02-06 1:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 19:01 [PATCH net-next 0/3] net: improve core queue API handling while device is down Jakub Kicinski
2025-02-05 19:01 ` [PATCH net-next 1/3] net: refactor netdev_rx_queue_restart() to use local qops Jakub Kicinski
2025-02-05 20:27 ` Mina Almasry
2025-02-05 19:01 ` [PATCH net-next 2/3] net: devmem: don't call queue stop / start when the interface is down Jakub Kicinski
2025-02-05 20:35 ` Mina Almasry
2025-02-06 1:26 ` Jakub Kicinski [this message]
2025-02-06 16:34 ` Mina Almasry
2025-02-05 19:01 ` [PATCH net-next 3/3] netdevsim: allow normal queue reset while down Jakub Kicinski
2025-02-06 16:43 ` Mina Almasry
2025-02-06 17:17 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250205172632.61f41a06@kernel.org \
--to=kuba@kernel.org \
--cc=almasrymina@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).