* [PATCH iwl-net v1 1/1] igc: Set buffer type for empty frames in igc_init_empty_frame
@ 2025-02-05 2:36 Song Yoong Siang
2025-02-05 11:14 ` Maciej Fijalkowski
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Song Yoong Siang @ 2025-02-05 2:36 UTC (permalink / raw)
To: Tony Nguyen, Przemek Kitszel, Andrew Lunn, David S . Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Vinicius Costa Gomes,
Malli C, Maciej Fijalkowski
Cc: intel-wired-lan, netdev, linux-kernel, stable
Set the buffer type to IGC_TX_BUFFER_TYPE_SKB for empty frame in the
igc_init_empty_frame function. This ensures that the buffer type is
correctly identified and handled during Tx ring cleanup.
Fixes: db0b124f02ba ("igc: Enhance Qbv scheduling by using first flag bit")
Cc: stable@vger.kernel.org # 6.2+
Signed-off-by: Song Yoong Siang <yoong.siang.song@intel.com>
---
drivers/net/ethernet/intel/igc/igc_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
index 56a35d58e7a6..7daa7f8f81ca 100644
--- a/drivers/net/ethernet/intel/igc/igc_main.c
+++ b/drivers/net/ethernet/intel/igc/igc_main.c
@@ -1096,6 +1096,7 @@ static int igc_init_empty_frame(struct igc_ring *ring,
return -ENOMEM;
}
+ buffer->type = IGC_TX_BUFFER_TYPE_SKB;
buffer->skb = skb;
buffer->protocol = 0;
buffer->bytecount = skb->len;
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH iwl-net v1 1/1] igc: Set buffer type for empty frames in igc_init_empty_frame
2025-02-05 2:36 [PATCH iwl-net v1 1/1] igc: Set buffer type for empty frames in igc_init_empty_frame Song Yoong Siang
@ 2025-02-05 11:14 ` Maciej Fijalkowski
2025-02-05 20:10 ` Simon Horman
2025-02-11 13:57 ` [Intel-wired-lan] " Mor Bar-Gabay
2 siblings, 0 replies; 4+ messages in thread
From: Maciej Fijalkowski @ 2025-02-05 11:14 UTC (permalink / raw)
To: Song Yoong Siang
Cc: Tony Nguyen, Przemek Kitszel, Andrew Lunn, David S . Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Vinicius Costa Gomes,
Malli C, intel-wired-lan, netdev, linux-kernel, stable
On Wed, Feb 05, 2025 at 10:36:03AM +0800, Song Yoong Siang wrote:
> Set the buffer type to IGC_TX_BUFFER_TYPE_SKB for empty frame in the
> igc_init_empty_frame function. This ensures that the buffer type is
> correctly identified and handled during Tx ring cleanup.
>
> Fixes: db0b124f02ba ("igc: Enhance Qbv scheduling by using first flag bit")
> Cc: stable@vger.kernel.org # 6.2+
> Signed-off-by: Song Yoong Siang <yoong.siang.song@intel.com>
Acked-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
> ---
> drivers/net/ethernet/intel/igc/igc_main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
> index 56a35d58e7a6..7daa7f8f81ca 100644
> --- a/drivers/net/ethernet/intel/igc/igc_main.c
> +++ b/drivers/net/ethernet/intel/igc/igc_main.c
> @@ -1096,6 +1096,7 @@ static int igc_init_empty_frame(struct igc_ring *ring,
> return -ENOMEM;
> }
>
> + buffer->type = IGC_TX_BUFFER_TYPE_SKB;
> buffer->skb = skb;
> buffer->protocol = 0;
> buffer->bytecount = skb->len;
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH iwl-net v1 1/1] igc: Set buffer type for empty frames in igc_init_empty_frame
2025-02-05 2:36 [PATCH iwl-net v1 1/1] igc: Set buffer type for empty frames in igc_init_empty_frame Song Yoong Siang
2025-02-05 11:14 ` Maciej Fijalkowski
@ 2025-02-05 20:10 ` Simon Horman
2025-02-11 13:57 ` [Intel-wired-lan] " Mor Bar-Gabay
2 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2025-02-05 20:10 UTC (permalink / raw)
To: Song Yoong Siang
Cc: Tony Nguyen, Przemek Kitszel, Andrew Lunn, David S . Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Vinicius Costa Gomes,
Malli C, Maciej Fijalkowski, intel-wired-lan, netdev,
linux-kernel, stable
On Wed, Feb 05, 2025 at 10:36:03AM +0800, Song Yoong Siang wrote:
> Set the buffer type to IGC_TX_BUFFER_TYPE_SKB for empty frame in the
> igc_init_empty_frame function. This ensures that the buffer type is
> correctly identified and handled during Tx ring cleanup.
>
> Fixes: db0b124f02ba ("igc: Enhance Qbv scheduling by using first flag bit")
> Cc: stable@vger.kernel.org # 6.2+
> Signed-off-by: Song Yoong Siang <yoong.siang.song@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Intel-wired-lan] [PATCH iwl-net v1 1/1] igc: Set buffer type for empty frames in igc_init_empty_frame
2025-02-05 2:36 [PATCH iwl-net v1 1/1] igc: Set buffer type for empty frames in igc_init_empty_frame Song Yoong Siang
2025-02-05 11:14 ` Maciej Fijalkowski
2025-02-05 20:10 ` Simon Horman
@ 2025-02-11 13:57 ` Mor Bar-Gabay
2 siblings, 0 replies; 4+ messages in thread
From: Mor Bar-Gabay @ 2025-02-11 13:57 UTC (permalink / raw)
To: Song Yoong Siang, Tony Nguyen, Przemek Kitszel, Andrew Lunn,
David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Vinicius Costa Gomes, Malli C, Maciej Fijalkowski
Cc: intel-wired-lan, netdev, linux-kernel, stable
On 05/02/2025 4:36, Song Yoong Siang wrote:
> Set the buffer type to IGC_TX_BUFFER_TYPE_SKB for empty frame in the
> igc_init_empty_frame function. This ensures that the buffer type is
> correctly identified and handled during Tx ring cleanup.
>
> Fixes: db0b124f02ba ("igc: Enhance Qbv scheduling by using first flag bit")
> Cc: stable@vger.kernel.org # 6.2+
> Signed-off-by: Song Yoong Siang <yoong.siang.song@intel.com>
> Acked-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
> Reviewed-by: Simon Horman <horms@kernel.org>
> ---
> drivers/net/ethernet/intel/igc/igc_main.c | 1 +
> 1 file changed, 1 insertion(+)
>
Tested-by: Mor Bar-Gabay <morx.bar.gabay@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-02-11 13:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-05 2:36 [PATCH iwl-net v1 1/1] igc: Set buffer type for empty frames in igc_init_empty_frame Song Yoong Siang
2025-02-05 11:14 ` Maciej Fijalkowski
2025-02-05 20:10 ` Simon Horman
2025-02-11 13:57 ` [Intel-wired-lan] " Mor Bar-Gabay
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).