Re: [PATCH net-next v4 1/8] netconsole: consolidate send buffers into netconsole_target struct

[Breno Leitao <leitao@debian.org>]

Hello Simon,

On Wed, Feb 05, 2025 at 01:34:55PM +0000, Simon Horman wrote:
> On Tue, Feb 04, 2025 at 03:35:09AM -0800, Breno Leitao wrote:
> > Move the static buffers from send_msg_no_fragmentation() and
> > send_msg_fragmented() into the netconsole_target structure. This
> > simplifies the code by:
> > - Eliminating redundant static buffers
> > - Centralizing buffer management in the target structure
> > - Reducing memory usage by 1KB (one buffer instead of two)
> > 
> > The buffer in netconsole_target is protected by target_list_lock,
> > maintaining the same synchronization semantics as the original code.
> > 
> > Suggested-by: Jakub Kicinski <kuba@kernel.org>
> > Signed-off-by: Breno Leitao <leitao@debian.org>
> > Reviewed-by: Simon Horman <horms@kernel.org>
> 
> Hi Breno,
> 
> Unfortunately this series did not apply to net-next cleanly,
> which trips up the Netdev CI. Could you rebase and repost?

Right, I was expecting it since I rebased it on top of the
netcons_frag_msgs selftest[1]. I've commented it in the cover page, but,
clearly it was not the best decision, since we missed the Netdev CI. So,
next time I will send it against pristine 'netnext/main' even if there
are oher conflicting patches being discussed.

[1] https://lore.kernel.org/all/20250203-netcons_frag_msgs-v1-1-5bc6bedf2ac0@debian.org/

> Also, one minor nit below.

I will update and send a new version.

Thanks for the review,
--breno