From: Jakub Kicinski <kuba@kernel.org>
To: Donald Hunter <donald.hunter@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org, donald.hunter@redhat.com
Subject: Re: [PATCH net-next v3 06/10] tools/net/ynl: sanitise enums with leading digits in ynl-gen-c
Date: Thu, 6 Feb 2025 08:10:33 -0800 [thread overview]
Message-ID: <20250206081033.49a7f4d6@kernel.org> (raw)
In-Reply-To: <20250206092658.1383-7-donald.hunter@gmail.com>
On Thu, 6 Feb 2025 09:26:54 +0000 Donald Hunter wrote:
> class Type(SpecAttr):
> + starts_with_digit = re.compile(r"^\d")
> +
> def __init__(self, family, attr_set, attr, value):
> super().__init__(family, attr_set, attr, value)
>
> @@ -74,6 +76,8 @@ class Type(SpecAttr):
> self.c_name = c_lower(self.name)
> if self.c_name in _C_KW:
> self.c_name += '_'
> + if self.starts_with_digit.match(self.c_name):
> + self.c_name = '_' + self.c_name
bit heavyweight with the regex? I think this would do:
if self.c_name[0].isdigit():
but either way:
Acked-by: Jakub Kicinski <kuba@kernel.org>
next prev parent reply other threads:[~2025-02-06 16:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 9:26 [PATCH net-next v3 00/10] netlink: specs: add a spec for nl80211 wiphy Donald Hunter
2025-02-06 9:26 ` [PATCH net-next v3 01/10] tools/net/ynl: remove extraneous plural from variable names Donald Hunter
2025-02-06 9:26 ` [PATCH net-next v3 02/10] tools/net/ynl: support decoding indexed arrays as enums Donald Hunter
2025-02-06 9:26 ` [PATCH net-next v3 03/10] tools/net/ynl: support rendering C array members to strings Donald Hunter
2025-02-06 9:26 ` [PATCH net-next v3 04/10] tools/net/ynl: accept IP string inputs Donald Hunter
2025-02-06 16:07 ` Jakub Kicinski
2025-02-06 9:26 ` [PATCH net-next v3 05/10] tools/net/ynl: add s8, s16 to valid scalars in ynl-gen-c Donald Hunter
2025-02-06 16:07 ` Jakub Kicinski
2025-02-06 9:26 ` [PATCH net-next v3 06/10] tools/net/ynl: sanitise enums with leading digits " Donald Hunter
2025-02-06 16:10 ` Jakub Kicinski [this message]
2025-02-07 9:24 ` Donald Hunter
2025-02-06 9:26 ` [PATCH net-next v3 07/10] tools/net/ynl: add indexed-array scalar support to ynl-gen-c Donald Hunter
2025-02-06 16:12 ` Jakub Kicinski
2025-02-06 9:26 ` [PATCH net-next v3 08/10] netlink: specs: support nested structs in genetlink legacy Donald Hunter
2025-02-06 9:26 ` [PATCH net-next v3 09/10] netlink: specs: add s8, s16 to genetlink schemas Donald Hunter
2025-02-06 9:26 ` [PATCH net-next v3 10/10] netlink: specs: wireless: add a spec for nl80211 Donald Hunter
2025-02-06 9:43 ` Johannes Berg
2025-02-06 12:12 ` Donald Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250206081033.49a7f4d6@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=donald.hunter@redhat.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).