[PATCH net-next] tcp: do not export tcp_parse_mss_option() and tcp_mtup_init()

[PATCH net-next] tcp: do not export tcp_parse_mss_option() and tcp_mtup_init()

[Eric Dumazet]

These two functions are not called from modules.

Signed-off-by: Eric Dumazet <edumazet@google.com>
---
 net/ipv4/tcp_input.c  | 1 -
 net/ipv4/tcp_output.c | 1 -
 2 files changed, 2 deletions(-)

diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index eb82e01da911048b41ca380f913ef55566be79a7..61da8ffc2f86fe59a1853a3651b2fc8d96bbe34a 100644
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -4174,7 +4174,6 @@ u16 tcp_parse_mss_option(const struct tcphdr *th, u16 user_mss)
 	}
 	return mss;
 }
-EXPORT_SYMBOL_GPL(tcp_parse_mss_option);
 
 /* Look for tcp options. Normally only called on SYN and SYNACK packets.
  * But, this can also be called on packets in the established flow when
diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
index bc95d2a5924fdc6ea609fa006432db9b13444706..ef9f6172680f5f3a9384132962d6e34cfbf83f14 100644
--- a/net/ipv4/tcp_output.c
+++ b/net/ipv4/tcp_output.c
@@ -1813,7 +1813,6 @@ void tcp_mtup_init(struct sock *sk)
 	if (icsk->icsk_mtup.enabled)
 		icsk->icsk_mtup.probe_timestamp = tcp_jiffies32;
 }
-EXPORT_SYMBOL(tcp_mtup_init);
 
 /* This function synchronize snd mss to current pmtu/exthdr set.
 
-- 
2.48.1.362.g079036d154-goog

Re: [PATCH net-next] tcp: do not export tcp_parse_mss_option() and tcp_mtup_init()

[Simon Horman]

On Thu, Feb 06, 2025 at 09:34:36AM +0000, Eric Dumazet wrote:
> These two functions are not called from modules.
> 
> Signed-off-by: Eric Dumazet <edumazet@google.com>

Reviewed-by: Simon Horman <horms@kernel.org>

Re: [PATCH net-next] tcp: do not export tcp_parse_mss_option() and tcp_mtup_init()

[Joe Damato]

On Thu, Feb 06, 2025 at 09:34:36AM +0000, Eric Dumazet wrote:
> These two functions are not called from modules.
> 
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> ---
>  net/ipv4/tcp_input.c  | 1 -
>  net/ipv4/tcp_output.c | 1 -
>  2 files changed, 2 deletions(-)

Reviewed-by: Joe Damato <jdamato@fastly.com>

Re: [PATCH net-next] tcp: do not export tcp_parse_mss_option() and tcp_mtup_init()

[Kuniyuki Iwashima]

From: Eric Dumazet <edumazet@google.com>
Date: Thu,  6 Feb 2025 09:34:36 +0000
> These two functions are not called from modules.
> 
> Signed-off-by: Eric Dumazet <edumazet@google.com>

Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>

Re: [PATCH net-next] tcp: do not export tcp_parse_mss_option() and tcp_mtup_init()

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu,  6 Feb 2025 09:34:36 +0000 you wrote:
> These two functions are not called from modules.
> 
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> ---
>  net/ipv4/tcp_input.c  | 1 -
>  net/ipv4/tcp_output.c | 1 -
>  2 files changed, 2 deletions(-)

Here is the summary with links:
  - [net-next] tcp: do not export tcp_parse_mss_option() and tcp_mtup_init()
    https://git.kernel.org/netdev/net-next/c/d876ec8d3ed3

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html