From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
andrew+netdev@lunn.ch, horms@kernel.org, almasrymina@google.com,
Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH net-next v2 0/4] net: improve core queue API handling while device is down
Date: Thu, 6 Feb 2025 14:56:34 -0800 [thread overview]
Message-ID: <20250206225638.1387810-1-kuba@kernel.org> (raw)
The core netdev_rx_queue_restart() doesn't currently take into account
that the device may be down. The current and proposed queue API
implementations deal with this by rejecting queue API calls while
the device is down. We can do better, in theory we can still allow
devmem binding when the device is down - we shouldn't stop and start
the queues just try to allocate the memory. The reason we allocate
the memory is that memory provider binding checks if any compatible
page pool has been created (page_pool_check_memory_provider()).
Alternatively we could reject installing MP while the device is down
but the MP assignment survives ifdown (so presumably MP doesn't cease
to exist while down), and in general we allow configuration while down.
Previously I thought we need this as a fix, but gve rejects page pool
calls while down, and so did Saeed in the patches he posted. So this
series just makes the core act more sensibly but practically should
be a noop for now.
v2:
- allow also mode 2 and 3 (patch 3 is new)
v1: https://lore.kernel.org/20250205190131.564456-1-kuba@kernel.org
Jakub Kicinski (4):
net: refactor netdev_rx_queue_restart() to use local qops
net: devmem: don't call queue stop / start when the interface is down
net: page_pool: avoid false positive warning if NAPI was never added
netdevsim: allow normal queue reset while down
include/net/netdev_queues.h | 4 +++
net/core/dev.h | 12 ++++++++
drivers/net/netdevsim/netdev.c | 10 +++----
net/core/netdev_rx_queue.c | 37 +++++++++++++-----------
net/core/page_pool.c | 7 ++---
tools/testing/selftests/net/nl_netdev.py | 18 +++++++++++-
6 files changed, 59 insertions(+), 29 deletions(-)
--
2.48.1
next reply other threads:[~2025-02-06 22:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 22:56 Jakub Kicinski [this message]
2025-02-06 22:56 ` [PATCH net-next v2 1/4] net: refactor netdev_rx_queue_restart() to use local qops Jakub Kicinski
2025-02-06 23:05 ` Mina Almasry
2025-02-06 23:06 ` Jakub Kicinski
2025-02-06 22:56 ` [PATCH net-next v2 2/4] net: devmem: don't call queue stop / start when the interface is down Jakub Kicinski
2025-02-06 23:12 ` Mina Almasry
2025-02-06 22:56 ` [PATCH net-next v2 3/4] net: page_pool: avoid false positive warning if NAPI was never added Jakub Kicinski
2025-02-07 0:32 ` Mina Almasry
2025-02-06 22:56 ` [PATCH net-next v2 4/4] netdevsim: allow normal queue reset while down Jakub Kicinski
2025-02-07 0:55 ` Mina Almasry
2025-02-08 4:20 ` [PATCH net-next v2 0/4] net: improve core queue API handling while device is down patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250206225638.1387810-1-kuba@kernel.org \
--to=kuba@kernel.org \
--cc=almasrymina@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).