From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jeremy Kerr <jk@codeconstruct.com.au>
Cc: Matt Johnston <matt@codeconstruct.com.au>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-usb@vger.kernel.org,
Santosh Puranik <spuranik@nvidia.com>
Subject: Re: [PATCH net-next 1/2] usb: Add base USB MCTP definitions
Date: Thu, 6 Feb 2025 08:22:47 +0100 [thread overview]
Message-ID: <2025020634-statute-ribbon-90a8@gregkh> (raw)
In-Reply-To: <a927fbb40ce2f89c57b427d4dabe5f730a523d80.camel@codeconstruct.com.au>
On Thu, Feb 06, 2025 at 03:11:25PM +0800, Jeremy Kerr wrote:
> Hi Greg,
>
> Thanks for the review.
>
> > > --- /dev/null
> > > +++ b/include/linux/usb/mctp-usb.h
> > > @@ -0,0 +1,28 @@
> > > +/* SPDX-License-Identifier: GPL-2.0+ */
> > > +/*
> > > + * mctp-usb.h - MCTP USB transport binding: common definitions.
> > > + *
> > > + * These are protocol-level definitions, that may be shared between host
> > > + * and gadget drivers.
> >
> > Perhaps add a link to the spec?
>
> Can do. I have one in the actual driver, but can replicate that here if
> it's helpful.
Isn't this a usb.org spec and not a vendor-specific one?
> > > + * Copyright (C) 2024 Code Construct Pty Ltd
> >
> > It's 2025 now :)
>
> WHAT?!
>
> :D
>
> (this was started in 2024, and I have some preliminary versions up since
> then, but I assume the last date is preferrable)
As per copyright norms, list the real dates, so that would be:
Copyright (C) 2024-2025 ...
thanks,
greg k-h
next prev parent reply other threads:[~2025-02-06 7:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 6:48 [PATCH net-next 0/2] mctp: Add MCTP-over-USB hardware transport binding Jeremy Kerr
2025-02-06 6:48 ` [PATCH net-next 1/2] usb: Add base USB MCTP definitions Jeremy Kerr
2025-02-06 7:03 ` Greg Kroah-Hartman
2025-02-06 7:11 ` Jeremy Kerr
2025-02-06 7:22 ` Greg Kroah-Hartman [this message]
2025-02-06 7:36 ` Jeremy Kerr
2025-02-06 8:14 ` Greg Kroah-Hartman
2025-02-06 6:48 ` [PATCH net-next 2/2] net: mctp: Add MCTP USB transport driver Jeremy Kerr
2025-02-06 7:07 ` Greg Kroah-Hartman
2025-02-07 8:49 ` Jeremy Kerr
2025-02-07 9:10 ` Greg Kroah-Hartman
2025-02-07 9:45 ` Jeremy Kerr
2025-02-07 12:18 ` Greg Kroah-Hartman
2025-02-06 11:12 ` Oliver Neukum
2025-02-07 7:45 ` Jeremy Kerr
2025-02-07 15:26 ` Simon Horman
2025-02-10 1:57 ` Jeremy Kerr
2025-02-20 18:13 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025020634-statute-ribbon-90a8@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jk@codeconstruct.com.au \
--cc=kuba@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=matt@codeconstruct.com.au \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=spuranik@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).