From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE4DB7FD; Fri, 7 Feb 2025 13:09:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738933790; cv=none; b=Uj8DXRgNnxy1wc7M8mIblZZItlFeii0czFnTNfZrybkr4/oj+WKRX+rBY4gwmPh+algLYprfLuZkLztsn3Lq3NI5jZWEab1WEgzc/oPAsUcJrk+3HI+c/FMluZnuWmzQKGW7/rP/C2DaegxPQNgCmqmrhWiutlVrYGfnkhbK3U4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738933790; c=relaxed/simple; bh=sWtdXVwApUDLMddu467r/8NkDwFjBjFHXobyYl0Fbpw=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=I1rv9WKrIeFFwAtX0LKH1ubgxKY4xzjJVx4WR/JqDRZJjRhAM8vVhEXiXHXjYT13BA9CyA2UrhJroa41X1/9HejERYlxUf4APWtYLOb7tyh81W3MtFrl5iouLZwHASubrEeWud+0mLblqohkjjp4/RFXSVHs/83eeSK6+2YrUqQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4YqDl86Gs9z67MQZ; Fri, 7 Feb 2025 21:07:00 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 9D3AD140B55; Fri, 7 Feb 2025 21:09:45 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 7 Feb 2025 14:09:44 +0100 Date: Fri, 7 Feb 2025 13:09:43 +0000 From: Jonathan Cameron To: Jason Gunthorpe CC: Andy Gospodarek , Aron Silverton , Dan Williams , Daniel Vetter , Dave Jiang , David Ahern , Andy Gospodarek , Christoph Hellwig , Itay Avraham , Jiri Pirko , Jakub Kicinski , Leonid Bloch , Leon Romanovsky , , , , Saeed Mahameed , "Nelson, Shannon" Subject: Re: [PATCH v4 04/10] taint: Add TAINT_FWCTL Message-ID: <20250207130943.00005b53@huawei.com> In-Reply-To: <4-v4-0cf4ec3b8143+4995-fwctl_jgg@nvidia.com> References: <0-v4-0cf4ec3b8143+4995-fwctl_jgg@nvidia.com> <4-v4-0cf4ec3b8143+4995-fwctl_jgg@nvidia.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml500012.china.huawei.com (7.191.174.4) To frapeml500008.china.huawei.com (7.182.85.71) On Thu, 6 Feb 2025 20:13:26 -0400 Jason Gunthorpe wrote: > Requesting a fwctl scope of access that includes mutating device debug > data will cause the kernel to be tainted. Changing the device operation > through things in the debug scope may cause the device to malfunction in > undefined ways. This should be reflected in the TAINT flags to help any > debuggers understand that something has been done. > > Signed-off-by: Jason Gunthorpe Not something I've ever directly touched before, so more eyes on this would be good, but FWIW looks inline with other flags and the general principle seems sensible to me. Reviewed-by: Jonathan Cameron