From: Simon Horman <horms@kernel.org>
To: Joe Damato <jdamato@fastly.com>
Cc: netdev@vger.kernel.org, pabeni@redhat.com, edumazet@google.com,
sridhar.samudrala@intel.com, Jakub Kicinski <kuba@kernel.org>,
Donald Hunter <donald.hunter@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Stanislav Fomichev <sdf@fomichev.me>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
Mina Almasry <almasrymina@google.com>,
Daniel Jurgens <danielj@nvidia.com>,
Amritha Nambiar <amritha.nambiar@intel.com>,
David Wei <dw@davidwei.uk>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v4 2/3] netdev-genl: Add an XSK attribute to queues
Date: Fri, 7 Feb 2025 13:30:55 +0000 [thread overview]
Message-ID: <20250207133055.GU554665@kernel.org> (raw)
In-Reply-To: <20250207030916.32751-3-jdamato@fastly.com>
On Fri, Feb 07, 2025 at 03:08:54AM +0000, Joe Damato wrote:
> Expose a new per-queue nest attribute, xsk, which will be present for
> queues that are being used for AF_XDP. If the queue is not being used for
> AF_XDP, the nest will not be present.
>
> In the future, this attribute can be extended to include more data about
> XSK as it is needed.
>
> Signed-off-by: Joe Damato <jdamato@fastly.com>
> Suggested-by: Jakub Kicinski <kuba@kernel.org>
...
> diff --git a/net/core/netdev-genl.c b/net/core/netdev-genl.c
> index 0dcd4faefd8d..75ca111aa591 100644
> --- a/net/core/netdev-genl.c
> +++ b/net/core/netdev-genl.c
> @@ -380,6 +380,7 @@ netdev_nl_queue_fill_one(struct sk_buff *rsp, struct net_device *netdev,
> struct netdev_rx_queue *rxq;
> struct netdev_queue *txq;
> void *hdr;
> + int ret;
>
Hi Joe,
Perhaps this got left behind after some revisions elsewhere.
But as it stands ret is unused in this function and should be removed.
> hdr = genlmsg_iput(rsp, info);
> if (!hdr)
...
--
pw-bot: changes-requested
next prev parent reply other threads:[~2025-02-07 13:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-07 3:08 [PATCH net-next v4 0/3] netdev-genl: Add an xsk attribute to queues Joe Damato
2025-02-07 3:08 ` [PATCH net-next v4 1/3] netlink: Add nla_put_empty_nest helper Joe Damato
2025-02-07 3:08 ` [PATCH net-next v4 2/3] netdev-genl: Add an XSK attribute to queues Joe Damato
2025-02-07 13:30 ` Simon Horman [this message]
2025-02-07 17:24 ` Joe Damato
2025-02-08 4:02 ` kernel test robot
2025-02-07 3:08 ` [PATCH net-next v4 3/3] selftests: drv-net: Test queue xsk attribute Joe Damato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250207133055.GU554665@kernel.org \
--to=horms@kernel.org \
--cc=almasrymina@google.com \
--cc=amritha.nambiar@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=danielj@nvidia.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=jdamato@fastly.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=sridhar.samudrala@intel.com \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).