From: Jakub Kicinski <kuba@kernel.org>
To: Gerhard Engleder <gerhard@engleder-embedded.com>
Cc: andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v5 2/7] net: phy: Support speed selection for PHY loopback
Date: Fri, 7 Feb 2025 16:16:14 -0800 [thread overview]
Message-ID: <20250207161614.6a70bef6@kernel.org> (raw)
In-Reply-To: <20250205190823.23528-3-gerhard@engleder-embedded.com>
On Wed, 5 Feb 2025 20:08:18 +0100 Gerhard Engleder wrote:
> +/**
> + * phy_loopback - Configure loopback mode of PHY
> + * @phydev: target phy_device struct
> + * @enable: enable or disable loopback mode
> + * @speed: enable loopback mode with speed
> + *
> + * Configure loopback mode of PHY and signal link down and link up if speed is
> + * changing.
> + */
> +int phy_loopback(struct phy_device *phydev, bool enable, int speed)
nit: if you're adding kdoc please also document the return value.
* Return: 0 on success, negative error code on failure.
--
pw-bot: cr
next prev parent reply other threads:[~2025-02-08 0:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 19:08 [PATCH net-next v5 0/7] Support loopback mode speed selection Gerhard Engleder
2025-02-05 19:08 ` [PATCH net-next v5 1/7] net: phy: Allow loopback speed selection for PHY drivers Gerhard Engleder
2025-02-05 19:08 ` [PATCH net-next v5 2/7] net: phy: Support speed selection for PHY loopback Gerhard Engleder
2025-02-08 0:16 ` Jakub Kicinski [this message]
2025-02-09 18:52 ` Gerhard Engleder
2025-02-05 19:08 ` [PATCH net-next v5 3/7] net: phy: micrel: Add loopback support Gerhard Engleder
2025-02-05 19:08 ` [PATCH net-next v5 4/7] net: phy: marvell: Align set_loopback() implementation Gerhard Engleder
2025-02-05 19:08 ` [PATCH net-next v5 5/7] tsnep: Select speed for loopback Gerhard Engleder
2025-02-05 19:08 ` [PATCH net-next v5 6/7] net: selftests: Export net_test_phy_loopback_* Gerhard Engleder
2025-02-05 19:08 ` [PATCH net-next v5 7/7] tsnep: Add PHY loopback selftests Gerhard Engleder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250207161614.6a70bef6@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gerhard@engleder-embedded.com \
--cc=hkallweit1@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).