From: Jakub Kicinski <kuba@kernel.org>
To: Piotr Wejman <wejmanpm@gmail.com>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net: e1000e: convert to ndo_hwtstamp_get() and ndo_hwtstamp_set()
Date: Mon, 10 Feb 2025 06:58:26 -0800 [thread overview]
Message-ID: <20250210065826.63a8822d@kernel.org> (raw)
In-Reply-To: <20250208154350.75316-1-wejmanpm@gmail.com>
On Sat, 8 Feb 2025 16:43:49 +0100 Piotr Wejman wrote:
> - if (!(adapter->flags & FLAG_HAS_HW_TIMESTAMP))
> + if (!(adapter->flags & FLAG_HAS_HW_TIMESTAMP)) {
> + NL_SET_ERR_MSG(extack, "No HW timestamp support\n");
No new lines at the end of extack messages, please.
User space adds its own line breaks.
--
pw-bot: cr
next prev parent reply other threads:[~2025-02-10 14:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-08 15:43 [PATCH v2] net: e1000e: convert to ndo_hwtstamp_get() and ndo_hwtstamp_set() Piotr Wejman
2025-02-10 9:13 ` Vadim Fedorenko
2025-02-10 14:58 ` Jakub Kicinski [this message]
2025-02-12 14:07 ` [Intel-wired-lan] " Lifshits, Vitaly
2025-02-12 22:32 ` Piotr Wejman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250210065826.63a8822d@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=wejmanpm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).