netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Xiao Liang <shaw.leon@gmail.com>
To: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
	Kuniyuki Iwashima <kuniyu@amazon.com>,
	Jakub Kicinski <kuba@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
	David Ahern <dsahern@kernel.org>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	Simon Horman <horms@kernel.org>, Shuah Khan <shuah@kernel.org>,
	Donald Hunter <donald.hunter@gmail.com>,
	Alexander Aring <alex.aring@gmail.com>,
	Stefan Schmidt <stefan@datenfreihafen.org>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Steffen Klassert <steffen.klassert@secunet.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	linux-rdma@vger.kernel.org, linux-can@vger.kernel.org,
	osmocom-net-gprs@lists.osmocom.org, bpf@vger.kernel.org,
	linux-ppp@vger.kernel.org, wireguard@lists.zx2c4.com,
	linux-wireless@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org,
	bridge@lists.linux.dev, linux-wpan@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH net-next v9 04/11] ieee802154: 6lowpan: Validate link netns in newlink() of rtnl_link_ops
Date: Mon, 10 Feb 2025 21:29:55 +0800	[thread overview]
Message-ID: <20250210133002.883422-5-shaw.leon@gmail.com> (raw)
In-Reply-To: <20250210133002.883422-1-shaw.leon@gmail.com>

Device denoted by IFLA_LINK is in link_net (IFLA_LINK_NETNSID) or
source netns by design, but 6lowpan uses dev_net.

Note dev->netns_local is set to true and currently link_net is
implemented via a netns change. These together effectively reject
IFLA_LINK_NETNSID.

This patch adds a validation to ensure link_net is either NULL or
identical to dev_net. Thus it would be fine to continue using dev_net
when rtnetlink core begins to create devices directly in target netns.

Signed-off-by: Xiao Liang <shaw.leon@gmail.com>
---
 net/ieee802154/6lowpan/core.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/net/ieee802154/6lowpan/core.c b/net/ieee802154/6lowpan/core.c
index 704bf9e3f097..ee318d46817d 100644
--- a/net/ieee802154/6lowpan/core.c
+++ b/net/ieee802154/6lowpan/core.c
@@ -143,6 +143,8 @@ static int lowpan_newlink(struct net_device *ldev,
 
 	if (!tb[IFLA_LINK])
 		return -EINVAL;
+	if (params->link_net && !net_eq(params->link_net, dev_net(ldev)))
+		return -EINVAL;
 	/* find and hold wpan device */
 	wdev = dev_get_by_index(dev_net(ldev), nla_get_u32(tb[IFLA_LINK]));
 	if (!wdev)
-- 
2.48.1


  parent reply	other threads:[~2025-02-10 13:30 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-10 13:29 [PATCH net-next v9 00/11] net: Improve netns handling in rtnetlink Xiao Liang
2025-02-10 13:29 ` [PATCH net-next v9 01/11] rtnetlink: Lookup device in target netns when creating link Xiao Liang
2025-02-10 13:29 ` [PATCH net-next v9 02/11] rtnetlink: Pack newlink() params into struct Xiao Liang
2025-02-13  6:53   ` Kuniyuki Iwashima
2025-02-13  8:36     ` Xiao Liang
2025-02-13  9:17       ` Paolo Abeni
2025-02-13 10:01         ` Xiao Liang
2025-02-10 13:29 ` [PATCH net-next v9 03/11] net: Use link netns in newlink() of rtnl_link_ops Xiao Liang
2025-02-13  6:55   ` Kuniyuki Iwashima
2025-02-10 13:29 ` Xiao Liang [this message]
2025-02-13  5:48   ` [PATCH net-next v9 04/11] ieee802154: 6lowpan: Validate " Kuniyuki Iwashima
2025-02-10 13:29 ` [PATCH net-next v9 05/11] net: ip_tunnel: Use " Xiao Liang
2025-02-13  6:20   ` Kuniyuki Iwashima
2025-02-13  8:27     ` Xiao Liang
2025-02-10 13:29 ` [PATCH net-next v9 06/11] net: ipv6: " Xiao Liang
2025-02-13  7:05   ` Kuniyuki Iwashima
2025-02-13  8:37     ` Xiao Liang
2025-02-13  9:55       ` Xiao Liang
2025-02-13 11:00         ` Kuniyuki Iwashima
2025-02-14  9:22           ` Xiao Liang
2025-02-14 10:51             ` Kuniyuki Iwashima
2025-02-10 13:29 ` [PATCH net-next v9 07/11] net: xfrm: " Xiao Liang
2025-02-10 13:29 ` [PATCH net-next v9 08/11] rtnetlink: Remove "net" from newlink params Xiao Liang
2025-02-10 13:30 ` [PATCH net-next v9 09/11] rtnetlink: Create link directly in target net namespace Xiao Liang
2025-02-10 13:30 ` [PATCH net-next v9 10/11] selftests: net: Add python context manager for netns entering Xiao Liang
2025-02-10 13:30 ` [PATCH net-next v9 11/11] selftests: net: Add test cases for link and peer netns Xiao Liang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250210133002.883422-5-shaw.leon@gmail.com \
    --to=shaw.leon@gmail.com \
    --cc=alex.aring@gmail.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    --cc=bpf@vger.kernel.org \
    --cc=bridge@lists.linux.dev \
    --cc=davem@davemloft.net \
    --cc=donald.hunter@gmail.com \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=kuniyu@amazon.com \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-ppp@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linux-wpan@vger.kernel.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=netdev@vger.kernel.org \
    --cc=osmocom-net-gprs@lists.osmocom.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    --cc=stefan@datenfreihafen.org \
    --cc=steffen.klassert@secunet.com \
    --cc=wireguard@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).