From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3FB8B676; Tue, 11 Feb 2025 01:56:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739239017; cv=none; b=LRHQk/ChpeY79PuDss07rpMATbEuy3enr55U9dNppe+m+OIHoXrS2yj2iqHMHJeK+0OZONxrRLLUMyuCaXUb7mW3kd2t1u/nMxMCapq6N2zBFcLxlPnnQkQScE/EC0TFPGjSr3S2DuIJUcfz4g0R4SQYXTo2AibTLMDHU0dCP3E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739239017; c=relaxed/simple; bh=JBSsbLlRcnXVLndhpHzyIz4BCKHwBTs9BNQ8fcPk/8U=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=DJKY3mMpnc4OuFXbGo4KQNyraN6goQqMkz0CuZQVheOXHJDsYaHhl1IWaoJzpXWr/kshIYtJXlPNw18DnlLrMPLLVuHc5i0UpdDXKXyyyUn8yRmwlVIk8nSYsCX9koLJ9HazU5/LnRlaU+itpCZb+GDs3Gy2nWoPanUa+8gVtTk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GBG0xO58; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GBG0xO58" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AEEF9C4CED1; Tue, 11 Feb 2025 01:56:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739239017; bh=JBSsbLlRcnXVLndhpHzyIz4BCKHwBTs9BNQ8fcPk/8U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GBG0xO58q4NUw7aNkm5a+Hg66ElniqttFVbAOoOmcwHHYUS7HzxtDQodv3vY6ZgmH 0x5cbyHaOdfzeOWDkxPZMidZ+qnOpawdfJw5n/wInSgPoiLXBpNblCpIoTyn18vKCx evTS97adKqeiApOdy6hAJQyxYarTkWmpOoL11MaV10kgv99niiOrFKRCHo+cskkbF/ WSxv1XAgNpcszYYD3lPWffiVVmFSB/dBLeOTRZCsYCnguSWLRJDwipQvJ+GRkSR2p8 +9qu4hGiVWfFsEhXh7gE2We5OMp4MJm+D1qRNFrXPxxYXK2q921KlG2zNTVG31TsAZ n21w7XenYDp+g== Date: Mon, 10 Feb 2025 17:56:55 -0800 From: Jakub Kicinski To: Simon Horman Cc: Alexander Lobakin , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Alexei Starovoitov , Daniel Borkmann , John Fastabend , Andrii Nakryiko , "Jose E. Marchesi" , Toke =?UTF-8?B?SMO4aWxh?= =?UTF-8?B?bmQtSsO4cmdlbnNlbg==?= , Magnus Karlsson , Maciej Fijalkowski , Przemek Kitszel , Jason Baron , Casey Schaufler , Nathan Chancellor , bpf@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 1/4] unroll: add generic loop unroll helpers Message-ID: <20250210175655.15c5fbe5@kernel.org> In-Reply-To: <20250210210819.GF554665@kernel.org> References: <20250206182630.3914318-1-aleksander.lobakin@intel.com> <20250206182630.3914318-2-aleksander.lobakin@intel.com> <20250209110725.GB554665@kernel.org> <20250210210819.GF554665@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 10 Feb 2025 21:08:19 +0000 Simon Horman wrote: > > > This patch adds four variants of the unrolled helper. But as far as I can > > > tell the patch-set only makes use of one of them, unrolled_count(). > > > > > > I think it would be best if this patch only added helpers that are used. > > > > I thought they might help people in future. > > I can remove them if you insist. BTW the original patch from Jose also > > added several variants. > > I do slightly prefer only adding what is used. Hm, I'm a bit on the fence. IDK how trivial it is to figure out how to get the equivalent behavior from the compilers... Let's keep it, if someone feels strongly I guess they could post a patch to delete the unused variants.