From: Simon Horman <horms@kernel.org>
To: Suman Ghosh <sumang@marvell.com>
Cc: sgoutham@marvell.com, gakula@marvell.com, sbhatta@marvell.com,
hkelam@marvell.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, lcherian@marvell.com,
jerinj@marvell.com, john.fastabend@gmail.com,
bbhushan2@marvell.com, hawk@kernel.org, andrew+netdev@lunn.ch,
ast@kernel.org, daniel@iogearbox.net, bpf@vger.kernel.org,
larysa.zaremba@intel.com
Subject: Re: [net-next PATCH v5 5/6] octeontx2-pf: Prepare for AF_XDP
Date: Mon, 10 Feb 2025 17:57:12 +0000 [thread overview]
Message-ID: <20250210175712.GK554665@kernel.org> (raw)
In-Reply-To: <20250206085034.1978172-6-sumang@marvell.com>
On Thu, Feb 06, 2025 at 02:20:33PM +0530, Suman Ghosh wrote:
> Implement necessary APIs required for AF_XDP transmit.
>
> Signed-off-by: Hariprasad Kelam <hkelam@marvell.com>
> Signed-off-by: Suman Ghosh <sumang@marvell.com>
...
> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c
> index 44137160bdf6..b012d8794f18 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c
> @@ -22,6 +22,12 @@
> #include "cn10k.h"
>
> #define CQE_ADDR(CQ, idx) ((CQ)->cqe_base + ((CQ)->cqe_size * (idx)))
> +#define READ_FREE_SQE(SQ, free_sqe) \
> + do { \
> + typeof(SQ) _SQ = (SQ); \
> + free_sqe = (((_SQ)->cons_head - (_SQ)->head - 1 + (_SQ)->sqe_cnt) \
> + & ((_SQ)->sqe_cnt - 1)); \
> + } while (0)
It looks like READ_FREE_SQE() could be a function rather than a macro.
And, as an aside, CQE_ADDR could be too.
> #define PTP_PORT 0x13F
> /* PTPv2 header Original Timestamp starts at byte offset 34 and
> * contains 6 byte seconds field and 4 byte nano seconds field.
...
next prev parent reply other threads:[~2025-02-10 17:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 8:50 [net-next PATCH v5 0/6] Add af_xdp support for cn10k Suman Ghosh
2025-02-06 8:50 ` [net-next PATCH v5 1/6] octeontx2-pf: use xdp_return_frame() to free xdp buffers Suman Ghosh
2025-02-10 16:25 ` Simon Horman
2025-02-10 17:53 ` Simon Horman
2025-02-12 6:45 ` [EXTERNAL] " Suman Ghosh
2025-02-12 6:44 ` Suman Ghosh
2025-02-10 17:54 ` Simon Horman
2025-02-12 6:52 ` [EXTERNAL] " Suman Ghosh
2025-02-06 8:50 ` [net-next PATCH v5 2/6] octeontx2-pf: Add AF_XDP non-zero copy support Suman Ghosh
2025-02-10 16:41 ` Simon Horman
2025-02-11 7:07 ` [EXTERNAL] " Suman Ghosh
2025-02-11 10:09 ` Simon Horman
2025-02-06 8:50 ` [net-next PATCH v5 3/6] octeontx2-pf: AF_XDP zero copy receive support Suman Ghosh
2025-02-10 17:56 ` Simon Horman
2025-02-12 7:32 ` [EXTERNAL] " Suman Ghosh
2025-02-06 8:50 ` [net-next PATCH v5 4/6] octeontx2-pf: Reconfigure RSS table after enabling AF_XDP zerocopy on rx queue Suman Ghosh
2025-02-06 8:50 ` [net-next PATCH v5 5/6] octeontx2-pf: Prepare for AF_XDP Suman Ghosh
2025-02-10 17:57 ` Simon Horman [this message]
2025-02-12 8:51 ` [EXTERNAL] " Suman Ghosh
2025-02-06 8:50 ` [net-next PATCH v5 6/6] octeontx2-pf: AF_XDP zero copy transmit support Suman Ghosh
2025-02-07 11:40 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250210175712.GK554665@kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=ast@kernel.org \
--cc=bbhushan2@marvell.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hawk@kernel.org \
--cc=hkelam@marvell.com \
--cc=jerinj@marvell.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=larysa.zaremba@intel.com \
--cc=lcherian@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
--cc=sumang@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).