From: Simon Horman <horms@kernel.org>
To: "Matthieu Baerts (NGI0)" <matttbe@kernel.org>
Cc: mptcp@lists.linux.dev, Mat Martineau <martineau@kernel.org>,
Geliang Tang <geliang@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 14/15] mptcp: pm: change rem type of set_flags
Date: Mon, 10 Feb 2025 19:52:43 +0000 [thread overview]
Message-ID: <20250210195243.GB554665@kernel.org> (raw)
In-Reply-To: <20250207-net-next-mptcp-pm-misc-cleanup-2-v3-14-71753ed957de@kernel.org>
On Fri, Feb 07, 2025 at 02:59:32PM +0100, Matthieu Baerts (NGI0) wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
>
> Generally, in the path manager interfaces, the local address is defined
> as an mptcp_pm_addr_entry type address, while the remote address is
> defined as an mptcp_addr_info type one:
>
> (struct mptcp_pm_addr_entry *local, struct mptcp_addr_info *remote)
>
> But the set_flags() interface uses two mptcp_pm_addr_entry type
> parameters.
>
> This patch changes the second one to mptcp_addr_info type and use helper
> mptcp_pm_parse_addr() to parse it instead of using mptcp_pm_parse_entry().
>
> Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
> Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-02-10 19:52 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-07 13:59 [PATCH net-next v3 00/15] mptcp: pm: misc cleanups, part 2 Matthieu Baerts (NGI0)
2025-02-07 13:59 ` [PATCH net-next v3 01/15] mptcp: pm: drop info of userspace_pm_remove_id_zero_address Matthieu Baerts (NGI0)
2025-02-10 19:49 ` Simon Horman
2025-02-11 9:31 ` Matthieu Baerts
2025-02-11 10:13 ` Simon Horman
2025-02-11 10:21 ` Matthieu Baerts
2025-02-07 13:59 ` [PATCH net-next v3 02/15] mptcp: pm: userspace: flags: clearer msg if no remote addr Matthieu Baerts (NGI0)
2025-02-10 19:49 ` Simon Horman
2025-02-07 13:59 ` [PATCH net-next v3 03/15] mptcp: pm: more precise error messages Matthieu Baerts (NGI0)
2025-02-10 19:50 ` Simon Horman
2025-02-07 13:59 ` [PATCH net-next v3 04/15] mptcp: pm: improve " Matthieu Baerts (NGI0)
2025-02-10 19:50 ` Simon Horman
2025-02-07 13:59 ` [PATCH net-next v3 05/15] mptcp: pm: userspace: use GENL_REQ_ATTR_CHECK Matthieu Baerts (NGI0)
2025-02-10 19:50 ` Simon Horman
2025-02-07 13:59 ` [PATCH net-next v3 06/15] mptcp: pm: remove duplicated error messages Matthieu Baerts (NGI0)
2025-02-10 19:50 ` Simon Horman
2025-02-07 13:59 ` [PATCH net-next v3 07/15] mptcp: pm: mark missing address attributes Matthieu Baerts (NGI0)
2025-02-10 19:51 ` Simon Horman
2025-02-07 13:59 ` [PATCH net-next v3 08/15] mptcp: pm: use NL_SET_ERR_MSG_ATTR when possible Matthieu Baerts (NGI0)
2025-02-10 19:51 ` Simon Horman
2025-02-07 13:59 ` [PATCH net-next v3 09/15] mptcp: pm: make three pm wrappers static Matthieu Baerts (NGI0)
2025-02-10 19:51 ` Simon Horman
2025-02-07 13:59 ` [PATCH net-next v3 10/15] mptcp: pm: drop skb parameter of get_addr Matthieu Baerts (NGI0)
2025-02-10 19:51 ` Simon Horman
2025-02-07 13:59 ` [PATCH net-next v3 11/15] mptcp: pm: add id parameter for get_addr Matthieu Baerts (NGI0)
2025-02-10 19:52 ` Simon Horman
2025-02-07 13:59 ` [PATCH net-next v3 12/15] mptcp: pm: reuse sending nlmsg code in get_addr Matthieu Baerts (NGI0)
2025-02-10 19:52 ` Simon Horman
2025-02-07 13:59 ` [PATCH net-next v3 13/15] mptcp: pm: drop skb parameter of set_flags Matthieu Baerts (NGI0)
2025-02-10 19:52 ` Simon Horman
2025-02-07 13:59 ` [PATCH net-next v3 14/15] mptcp: pm: change rem type " Matthieu Baerts (NGI0)
2025-02-10 19:52 ` Simon Horman [this message]
2025-02-07 13:59 ` [PATCH net-next v3 15/15] mptcp: pm: add local parameter for set_flags Matthieu Baerts (NGI0)
2025-02-10 19:52 ` Simon Horman
2025-02-11 12:00 ` [PATCH net-next v3 00/15] mptcp: pm: misc cleanups, part 2 patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250210195243.GB554665@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geliang@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martineau@kernel.org \
--cc=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).