From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C50F24E4A2; Mon, 10 Feb 2025 19:52:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739217167; cv=none; b=jQIQizdLt/1N31ujbXf9gUEF9KRz0vvxXXx8Rr1HdErLgglU+PfrRxOYxJZADLSJQX7F4bpD0YGn1T1sTJII4mNfJuRhNXWflfilWnYIktE5XrK/ModP2gcvP8hlZ9p5LUzi0gkkHKGvwvEkKxNJOMTpfqTebEUpbYXflwUW2ME= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739217167; c=relaxed/simple; bh=zbqmjJ/TxKX7U/m5+hgRgAGIrFw5+CmX9sFh4piK0QQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KCETnbD+ARqhxbWKJAm1GGkP3DEZ8Yb207et1+XcTxikKBh9aiXgLO3CywuwXMSJ/r0FCYCE8Lc579wA8terQb7EQvbJDNM58zDvOuiYGPJmcZ+RrJtoKGKGRVP/XCf6IXQvpH2Pp2dGR/4DpUExWGfq9dy8Wxga62iGpI3zMP4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Jq3/m16Y; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Jq3/m16Y" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EFAA1C4CED1; Mon, 10 Feb 2025 19:52:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739217166; bh=zbqmjJ/TxKX7U/m5+hgRgAGIrFw5+CmX9sFh4piK0QQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Jq3/m16YbpHRVW3WrViZSasayOPhOgS0RarkIDN/ckhjaXkLhhX27+jUBG205L/3/ gVM/zdrGSjchlJpkubN3yy9tIwqpI2M7Vo0kcs3OmorAv/YioarMOCPIeXestE1LPS eD4evm8zr84wT1WLNb+nfwy5fp+2I8A/NQxA6Qr/hfwG/fREK5EJIym1KpqfnUHzQx rlfPYW8rwuEHLEj/1B65MlSvY/qIpKfbmzLo6dw0HzFzfOgRenCX+NX4xZ792ip2Yu QSV34ZX91SAADWwMO7m2Y/xf7UWdiT6K1qHzQl3fC7gxlAvPWq0q3W2MduKzBlNKsZ t3j3Y+yAxZXvA== Date: Mon, 10 Feb 2025 19:52:43 +0000 From: Simon Horman To: "Matthieu Baerts (NGI0)" Cc: mptcp@lists.linux.dev, Mat Martineau , Geliang Tang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v3 14/15] mptcp: pm: change rem type of set_flags Message-ID: <20250210195243.GB554665@kernel.org> References: <20250207-net-next-mptcp-pm-misc-cleanup-2-v3-0-71753ed957de@kernel.org> <20250207-net-next-mptcp-pm-misc-cleanup-2-v3-14-71753ed957de@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250207-net-next-mptcp-pm-misc-cleanup-2-v3-14-71753ed957de@kernel.org> On Fri, Feb 07, 2025 at 02:59:32PM +0100, Matthieu Baerts (NGI0) wrote: > From: Geliang Tang > > Generally, in the path manager interfaces, the local address is defined > as an mptcp_pm_addr_entry type address, while the remote address is > defined as an mptcp_addr_info type one: > > (struct mptcp_pm_addr_entry *local, struct mptcp_addr_info *remote) > > But the set_flags() interface uses two mptcp_pm_addr_entry type > parameters. > > This patch changes the second one to mptcp_addr_info type and use helper > mptcp_pm_parse_addr() to parse it instead of using mptcp_pm_parse_entry(). > > Signed-off-by: Geliang Tang > Reviewed-by: Matthieu Baerts (NGI0) > Signed-off-by: Matthieu Baerts (NGI0) Reviewed-by: Simon Horman