netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wojtek Wasko <wwasko@nvidia.com>
To: netdev@vger.kernel.org
Cc: richardcochran@gmail.com, vadim.fedorenko@linux.dev,
	kuba@kernel.org, horms@kernel.org
Subject: [PATCH net-next v2 0/3] Permission checks for dynamic POSIX clocks
Date: Tue, 11 Feb 2025 17:09:10 +0200	[thread overview]
Message-ID: <20250211150913.772545-1-wwasko@nvidia.com> (raw)

Dynamic clocks - such as PTP clocks - extend beyond the standard POSIX
clock API by using ioctl calls. While file permissions are enforced for
standard POSIX operations, they are not implemented for ioctl calls,
since the POSIX layer cannot differentiate between calls which modify
the clock's state (like enabling PPS output generation) and those that
don't (such as retrieving the clock's PPS capabilities).

On the other hand, drivers implementing the dynamic clocks lack the
necessary information context to enforce permission checks themselves.

Add a struct file pointer to the POSIX clock context and use it to
implement the appropriate permission checks on PTP chardevs. Add a
readonly option to testptp.

Changes in v2:
- Store file pointer in POSIX clock context rather than fmode in the PTP
  clock's private data, as suggested by Richard.
- Move testptp.c changes into separate patch.

Wojtek Wasko (3):
  posix clocks: Store file pointer in clock context
  ptp: Add file permission checks on PHCs
  testptp: Add option to open PHC in readonly mode

 drivers/ptp/ptp_chardev.c             | 16 ++++++++++++
 include/linux/posix-clock.h           |  6 ++++-
 kernel/time/posix-clock.c             |  1 +
 tools/testing/selftests/ptp/testptp.c | 37 +++++++++++++++++----------
 4 files changed, 45 insertions(+), 15 deletions(-)

-- 
2.39.3


             reply	other threads:[~2025-02-11 15:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-11 15:09 Wojtek Wasko [this message]
2025-02-11 15:09 ` [PATCH net-next v2 1/3] posix clocks: Store file pointer in clock context Wojtek Wasko
2025-02-13 11:37   ` Paolo Abeni
2025-02-13 22:17     ` Thomas Gleixner
2025-02-14 11:14       ` Wojtek Wasko
2025-02-11 15:09 ` [PATCH net-next v2 2/3] ptp: Add file permission checks on PHCs Wojtek Wasko
2025-02-11 15:09 ` [PATCH net-next v2 3/3] testptp: Add option to open PHC in readonly mode Wojtek Wasko
2025-02-11 16:51 ` [PATCH net-next v2 0/3] Permission checks for dynamic POSIX clocks Richard Cochran
2025-02-11 17:07 ` Vadim Fedorenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250211150913.772545-1-wwasko@nvidia.com \
    --to=wwasko@nvidia.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=richardcochran@gmail.com \
    --cc=vadim.fedorenko@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).