netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: alexanderduyck@fb.com, netdev@vger.kernel.org,
	edumazet@google.com, pabeni@redhat.com, andrew+netdev@lunn.ch,
	horms@kernel.org, Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH net-next 0/5] eth: fbnic: report software queue stats
Date: Tue, 11 Feb 2025 10:13:51 -0800	[thread overview]
Message-ID: <20250211181356.580800-1-kuba@kernel.org> (raw)

Fill in typical software queue stats.

  # ./pyynl/cli.py --spec netlink/specs/netdev.yaml --dump qstats-get 
  [{'ifindex': 2,
    'rx-alloc-fail': 0,
    'rx-bytes': 398064076,
    'rx-csum-complete': 271,
    'rx-csum-none': 0,
    'rx-packets': 276044,
    'tx-bytes': 7223770,
    'tx-needs-csum': 28148,
    'tx-packets': 28449,
    'tx-stop': 0,
    'tx-wake': 0}]

Note that we don't collect csum-unnecessary, just the uncommon
cases (and unnecessary is all the rest of the packets). There
is no programatic use for these stats AFAIK, just manual debug.

Jakub Kicinski (5):
  net: report csum_complete via qstats
  eth: fbnic: wrap tx queue stats in a struct
  eth: fbnic: report software Rx queue stats
  eth: fbnic: report software Tx queue stats
  eth: fbnic: re-sort the objects in the Makefile

 drivers/net/ethernet/meta/fbnic/Makefile      |  3 +-
 drivers/net/ethernet/meta/fbnic/fbnic_txrx.h  | 16 +++-
 include/net/netdev_queues.h                   |  1 +
 .../net/ethernet/meta/fbnic/fbnic_ethtool.c   |  8 +-
 .../net/ethernet/meta/fbnic/fbnic_netdev.c    | 22 +++++-
 drivers/net/ethernet/meta/fbnic/fbnic_txrx.c  | 74 +++++++++++++++----
 net/core/netdev-genl.c                        |  1 +
 7 files changed, 102 insertions(+), 23 deletions(-)

-- 
2.48.1


             reply	other threads:[~2025-02-11 18:14 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-11 18:13 Jakub Kicinski [this message]
2025-02-11 18:13 ` [PATCH net-next 1/5] net: report csum_complete via qstats Jakub Kicinski
2025-02-11 19:34   ` Joe Damato
2025-02-11 18:13 ` [PATCH net-next 2/5] eth: fbnic: wrap tx queue stats in a struct Jakub Kicinski
2025-02-11 19:41   ` Joe Damato
2025-02-11 18:13 ` [PATCH net-next 3/5] eth: fbnic: report software Rx queue stats Jakub Kicinski
2025-02-11 19:49   ` Joe Damato
2025-02-11 18:13 ` [PATCH net-next 4/5] eth: fbnic: report software Tx " Jakub Kicinski
2025-02-11 19:52   ` Joe Damato
2025-02-11 18:13 ` [PATCH net-next 5/5] eth: fbnic: re-sort the objects in the Makefile Jakub Kicinski
2025-02-11 19:54   ` Joe Damato
2025-02-11 22:32     ` Jakub Kicinski
2025-02-12 16:17       ` Alexander Lobakin
2025-02-13  0:50 ` [PATCH net-next 0/5] eth: fbnic: report software queue stats patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250211181356.580800-1-kuba@kernel.org \
    --to=kuba@kernel.org \
    --cc=alexanderduyck@fb.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).