From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80FAE2B9BC; Wed, 12 Feb 2025 12:02:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739361766; cv=none; b=q5tKoa2k8d6u4dzznlcRFjwst7EL6xGVneeShYFs5BHDHVQFMwts6qnbNtst6VopSbtGqtw1BDKo/jHQQQvFY3jhQQNgMu4E56iawtn5zMVtvg2baayjYNtq/KuwtYq3wCLuaztbO54aTxIMtOWKGRX+4r2s8izPWsMxqpaoDKU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739361766; c=relaxed/simple; bh=PjF6JXkG05HXU8hwy/zyP4RcDynglgMR1RrFFX5ljmk=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=XPaPmL4hIQ3m7ynmJUW/LbNhuSLB1vu5do3UEpdwcKR2EkO2ux6hNsUBHC7p2DtepT0+jWGdiAnRWx6aHILcjbZXvoWMpSp3wZ0kO8W42kGs+o7lexj9Lk6bEMNbhl53dOD04coI40F0eW5o5d9ymWwtGHyXoF/Kuu4bkvC4NSk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4YtH3B3sbgz6HJbM; Wed, 12 Feb 2025 20:01:26 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 1BDB41402A4; Wed, 12 Feb 2025 20:02:42 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 12 Feb 2025 13:02:41 +0100 Date: Wed, 12 Feb 2025 12:02:39 +0000 From: Jonathan Cameron To: Shannon Nelson CC: , , , , , , , , , , , , , , , , , , Subject: Re: [RFC PATCH fwctl 2/5] pds_core: add new fwctl auxilary_device Message-ID: <20250212120239.00001f0a@huawei.com> In-Reply-To: <20250211234854.52277-3-shannon.nelson@amd.com> References: <20250211234854.52277-1-shannon.nelson@amd.com> <20250211234854.52277-3-shannon.nelson@amd.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml100009.china.huawei.com (7.191.174.83) To frapeml500008.china.huawei.com (7.182.85.71) On Tue, 11 Feb 2025 15:48:51 -0800 Shannon Nelson wrote: > Add support for a new fwctl-based auxiliary_device for creating a > channel for fwctl support into the AMD/Pensando DSC. > > Signed-off-by: Shannon Nelson Hi Shannon, > diff --git a/drivers/net/ethernet/amd/pds_core/main.c b/drivers/net/ethernet/amd/pds_core/main.c > index a3a68889137b..7f20c3f5f349 100644 > --- a/drivers/net/ethernet/amd/pds_core/main.c > +++ b/drivers/net/ethernet/amd/pds_core/main.c > @@ -265,6 +265,10 @@ static int pdsc_init_pf(struct pdsc *pdsc) > > mutex_unlock(&pdsc->config_lock); > > + err = pdsc_auxbus_dev_add(pdsc, pdsc, PDS_DEV_TYPE_FWCTL, &pdsc->padev); > + if (err) > + goto err_out_teardown; > + If you fail after this point, do you not want to remove this device? Also superficially shouldn't this be goto err_out_stop? I think the call is just after pdsc_start(pdsc) though maybe I'm looking at an old tree. > dl = priv_to_devlink(pdsc); > devl_lock(dl); > err = devl_params_register(dl, pdsc_dl_params,